Maniphest T265400

Research to create service for SessionManager::singleton()/getGlobalSession()
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Oct 13 2020, 7:48 PM

Tags

Referenced Files

None

Subscribers

Description

SessionManager::singleton() instance the object with global state, but the constructor allows injection with options

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+171 -243	Create SessionManager service

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T259960 Inject services into API modules and special pages
		Open		None	T306707 Container disabled! (JobQueue/MessageUpdateJob/PageUpdater/WikitextContentHandler/Parser/MWTimestamp/Message)
		Open		None	T265400 Research to create service for SessionManager::singleton()/getGlobalSession()

Event Timeline

Umherirrender created this task.Oct 13 2020, 7:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2020, 7:48 PM

Umherirrender added a subtask: T259960: Inject services into API modules and special pages.Oct 13 2020, 7:48 PM

Umherirrender removed a subtask: T259960: Inject services into API modules and special pages.Oct 13 2020, 8:15 PM

Umherirrender added a parent task: T259960: Inject services into API modules and special pages.

Umherirrender removed a subscriber: Umherirrender.Apr 4 2021, 7:51 PM

Func added a parent task: T306707: Container disabled! (JobQueue/MessageUpdateJob/PageUpdater/WikitextContentHandler/Parser/MWTimestamp/Message).Apr 24 2022, 4:51 AM

Direct construction with args is only used in tests, should be fine to be converted to service for T306707.
https://codesearch.wmcloud.org/search/?q=new%20SessionManager%5C(

Nikerabbit mentioned this in T307998: Unable to run ttmserver-export.php: Container disabled!.May 10 2022, 10:49 AM

Change 790665 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Create SessionManager service

https://gerrit.wikimedia.org/r/790665

gerritbot added a project: Patch-For-Review.May 10 2022, 12:14 PM