SessionManager::singleton() instance the object with global state, but the constructor allows injection with options
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | JTweed-WMF | T398814 WE5.1.1 Session storage protection | |||
| Resolved | JTweed-WMF | T400365 Support multiple session stores | |||
| Resolved | DAlangi_WMF | T394075 Investigate using different stores for different kinds of sessions | |||
| Open | None | T259960 Inject services into API modules and special pages | |||
| Resolved | None | T306707 Container disabled! (JobQueue/MessageUpdateJob/PageUpdater/WikitextContentHandler/Parser/MWTimestamp/Message) | |||
| Resolved | matmarex | T265400 Research to create service for SessionManager::singleton()/getGlobalSession() |
Event Timeline
Comment Actions
Direct construction with args is only used in tests, should be fine to be converted to service for T306707.
https://codesearch.wmcloud.org/search/?q=new%20SessionManager%5C(
Comment Actions
Change 790665 had a related patch set uploaded (by Func; author: Func):
[mediawiki/core@master] Create SessionManager service
Comment Actions
Change #790665 abandoned by Bartosz Dziewoński:
[mediawiki/core@master] Create SessionManager service
Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1166492 (I only found this after almost finishing that patch), but I'll take some advice from the comments here.
Comment Actions
Change #1166492 had a related patch set uploaded (by Bartosz Dziewoński; author: Derick Alangi):
[mediawiki/core@master] session: Make SessionManager use DI (step 2)
Comment Actions
Change #1172616 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/core@master] [WIP] Move SessionManager::getGlobalSession() to WebRequest
Comment Actions
Change #1166492 merged by jenkins-bot:
[mediawiki/core@master] session: Make SessionManager use DI (step 2)
Comment Actions
Change #1172616 merged by jenkins-bot:
[mediawiki/core@master] session: Move SessionManager::getGlobalSession() to WebRequest
Comment Actions
Change #1172923 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] session: Avoid references to deprecated SessionManager::singleton
Comment Actions
Change #1172923 merged by jenkins-bot:
[mediawiki/core@master] session: Avoid references to deprecated SessionManager::singleton