Page MenuHomePhabricator

Create a coverage job for skins
Open, Needs TriagePublic

Description

There seem to be no job template in integration-config to provide phpunit coverage for skins. We have achieve quite nice test coverage for WikimediaApiPortal skin, would be nice to be able to enable coverage job in CI.

Looking at mediawiki/skins.git, several MediaWiki skins do have PHPUnit tests (ls -1d */tests/phpunit):

BlueSpiceCalumma
MinervaNeue
Vector
WikimediaApiPortal

Event Timeline

Pchelolo created this task.Oct 13 2020, 8:53 PM
hashar updated the task description. (Show Details)Oct 14 2020, 8:03 AM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 14 2020, 8:03 AM

I had a very quick look at it, most of our logic to generate coverage for MediaWiki extensions has extensions hardcoded in. So we would need to do a bunch of refactoring or copy pasting to support skins as well. It is not the end of the world, but definitely a few hours to commit to.

Beside WikimediaApiPortal I have noticed a few more skins having PHPUnit tests which could benefit having coverage reports: BlueSpiceCalumma,
MinervaNeue and Vector.