Page MenuHomePhabricator

Use more Symfony features
Closed, DeclinedPublic

Description

This is a list of ideas/tasks that will improve the code base after the move to symfony

  • Inject dependencies (use cases, presenters, validators) into controllers as constructor dependencies instead of injecting the factory
  • Replace TwigFactory and twig instances for creating mails with service definitions
  • Use _format for ListCommentsController
  • Replace "EnvironmentBootstrapper" and its factory classes with service definitions for the different environments and rely on Symfony's dependency injection

Event Timeline

This is a vague ideas "Task" document where in hindsight the code quality/dev experience won't be improved by most of the changes outlines. We will do the EnvironmentBootstrapper-related stuff in {T342461: Change environment-specific setup for FunFunFactory}