Page MenuHomePhabricator

Outreachy Microtask: Check if '/tests/selenium/log' is included in .gitignore in all repositories with Selenium tests
Closed, ResolvedPublic

Description

Instructions:

  1. Pick any 3 repositories/extensions from the list given below
  2. Add your Phabricator Username next to the repository you pick by editing the task description
  3. Check the .gitignore file for P12611 in the repository you picked
  4. Create a patch by adding /tests/selenium/log in .gitignore if it is not present. (Set the topic to T265463 in Gerrit)
  5. If it is already present, mark the repository as done

Make sure you add your Phabricator Username next to the repository you pick before you start working on it to avoid multiple students working on the same repository


Repositories:

TODO

  • check if wikidata/query/gui needs the file

Details

ProjectBranchLines +/-Subject
wikidata/query/guimaster+1 -0
phabricator/deploymentwmf/stable+1 -0
wikimedia/portals/deploymaster+2 -1
mediawiki/extensions/WikibaseMediaInfomaster+1 -1
mediawiki/extensions/ORESmaster+1 -0
mediawiki/extensions/Mathmaster+1 -0
mediawiki/extensions/Wikibasemaster+2 -0
wikibase/termboxmaster+1 -0
mediawiki/extensions/TemplateWizardmaster+1 -0
mediawiki/extensions/Citemaster+1 -0
mediawiki/extensions/CirrusSearchmaster+1 -0
mediawiki/extensions/ElectronPdfServicemaster+1 -0
mediawiki/extensions/ProofreadPagemaster+1 -0
mediawiki/extensions/Echomaster+1 -0
mediawiki/extensions/RevisionSlidermaster+1 -0
mediawiki/extensions/TwoColConflictmaster+1 -0
mediawiki/extensions/Newslettermaster+1 -0
mediawiki/extensions/Newslettermaster+0 -1
mediawiki/extensions/AdvancedSearchmaster+1 -0
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 634393 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Added '/tests/selenium/log' in .gitignore

https://gerrit.wikimedia.org/r/634393

Change 634242 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Added '/tests/selenium/log' in .gitignore

https://gerrit.wikimedia.org/r/634242

Change 634353 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Add /tests/selenium/log to .gitignore file

https://gerrit.wikimedia.org/r/634353

Change 634343 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Add /tests/selenium/log to .gitignore file

https://gerrit.wikimedia.org/r/634343

Change 634347 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Add /tests/selenium/log to .gitignore file

https://gerrit.wikimedia.org/r/634347

Change 634394 merged by jenkins-bot:
[mediawiki/extensions/ElectronPdfService@master] Add '/tests/selenium/log' in .gitignore file.

https://gerrit.wikimedia.org/r/634394

Change 634296 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add /tests/selenium/log to .gitignore file

https://gerrit.wikimedia.org/r/634296

Change 634528 had a related patch set uploaded (by Sskenner; owner: Sskenner):
[mediawiki/extensions/Wikibase@master] build: Add /tests/selenium/log in .gitignore

https://gerrit.wikimedia.org/r/634528

Change 634529 had a related patch set uploaded (by Sskenner; owner: Sskenner):
[wikibase/termbox@master] build: Add /tests/selenium/log in .gitignore

https://gerrit.wikimedia.org/r/634529

Richa1496 updated the task description. (Show Details)
Richa1496 added a subscriber: Richa1496.
Richa1496 updated the task description. (Show Details)

Change 635354 had a related patch set uploaded (by Sskenner; owner: Sskenner):
[mediawiki/extensions/Cite@master] Selenium: Add selenium logs to .gitignore

https://gerrit.wikimedia.org/r/635354

santana updated the task description. (Show Details)

Change 635354 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Selenium: Add selenium logs to .gitignore

https://gerrit.wikimedia.org/r/635354

Change 634681 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Richa Sharma):
[mediawiki/extensions/TemplateWizard@master] Add tests/selenium/log to .gitignore

https://gerrit.wikimedia.org/r/634681

Change 634529 abandoned by Sskenner:
[wikibase/termbox@master] Selenium: Add selenium logs to .gitignore

Reason:
@Željko
I think we made a mistake with this repository. It doesn't need this folder in .gitignore because Selenium tests from this repository are always executed from Wikibase repository, so the logs will be created there.

This commit should be abandoned.

https://gerrit.wikimedia.org/r/634529

Change 634528 abandoned by Sskenner:
[mediawiki/extensions/Wikibase@master] Add /tests/selenium/log/ folder to .gitignore file

Reason:
Wikibase is a little different from other repos. Tests are present in a folder called repo. The selenium log is already mentioned in the .gitignore file at line 7. You can mark this repo as done.

https://gerrit.wikimedia.org/r/634528

Change 634681 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Add tests/selenium/log to .gitignore

https://gerrit.wikimedia.org/r/634681

Hello,

I picked up 3 repositories as below:

  • mediawiki/extensions/AbuseFilter --> Already have the path "/tests/selenium/log/" in .gitignore file -> done
  • mediawiki/extensions/RelatedArticles --> Already have the path "/tests/selenium/log/" in .gitignore file -> done
  • mediawiki/extensions/WikibaseMediaInfo --> The .gitignore file have "tests/selenium/log/" , So I changed the path to "/tests/selenium/log/" --> Review at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/636156

Thank you!

Change 634038 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Add /tests/selenium/log/ folder to .gitignore file

https://gerrit.wikimedia.org/r/634038

Change 637764 had a related patch set uploaded (by BlessingDickson; owner: BlessingDickson):
[mediawiki/extensions/ORES@master] Add /tests/selenium/log

https://gerrit.wikimedia.org/r/637764

Change 637764 had a related patch set uploaded (by BlessingDickson; owner: BlessingDickson):
[mediawiki/extensions/ORES@master] Add /tests/selenium/log to .gitignore

https://gerrit.wikimedia.org/r/637764

Change 637764 abandoned by Zfilipin:
[mediawiki/extensions/ORES@master] Add /tests/selenium/log to .gitignore

Reason:

https://gerrit.wikimedia.org/r/637764

Change 639269 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[wikidata/query/gui@master] Add /tests/selenium/log to .gitignore file

https://gerrit.wikimedia.org/r/639269

Change 639278 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[wikimedia/portals/deploy@master] Add tests/selenium/log to .gitignore

https://gerrit.wikimedia.org/r/639278

Change 639293 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[phabricator/deployment@wmf/stable] Add tests/selenium/log to .gitignore

https://gerrit.wikimedia.org/r/639293

Change 636156 had a related patch set uploaded (by Matthias Mullie; owner: vicky0602):
[mediawiki/extensions/WikibaseMediaInfo@master] Selenium: Add log folder to .gitignore

https://gerrit.wikimedia.org/r/636156

Change 636156 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Selenium: Add log folder to .gitignore

https://gerrit.wikimedia.org/r/636156

Change 639278 merged by jenkins-bot:
[wikimedia/portals/deploy@master] Add tests/selenium/log to .gitignore

https://gerrit.wikimedia.org/r/639278

Change 639293 merged by 20after4:
[phabricator/deployment@wmf/stable] Add tests/selenium/log to .gitignore

https://gerrit.wikimedia.org/r/639293

Change 639269 abandoned by Lucas Werkmeister (WMDE):
[wikidata/query/gui@master] Add /tests/selenium/log to .gitignore file

Reason:
not needed

https://gerrit.wikimedia.org/r/639269

zeljkofilipin updated the task description. (Show Details)

@Harriet: this is finally resolved! 🎉