Page MenuHomePhabricator

Allow users to turn on DiscussionTools via some JavaScript hack
Closed, ResolvedPublic

Description

We've realized that this change breaks the trick used to load the reply tool on pages (and wikis) where it's not supposed to be available, by using code like mw.loader.load( 'ext.discussionTools.init' ) in your common.js – that code will not cause any issues, but it will do nothing now. It has become surprisingly popular (currently 7 and 19 results in those searches)…

We probably want to support some alternative way of doing that, but we haven't quite figured out how. We'll do something about this before the production deployment.

Event Timeline

Esanders created this task.Oct 14 2020, 4:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2020, 4:33 PM

Change 634778 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Enable DT server side via a cookie to preserve user enable hack

https://gerrit.wikimedia.org/r/634778

Be aware the cookie will not have been set on the very first view of a talk page after this patch is deployed, so reload the page when testing.

The cookie will be set for a month, so in order to disable discussion tools you need to type

mw.cookie.set('discussiontools-tempenable', null)

into the console, after removing the hack from your common/global.js.

As before this is a temporary testing hack, not a feature, so use at your own risk, and there are no guarantees it will continue to work.

Change 634778 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Enable DT server side via a cookie to preserve user enable hack

https://gerrit.wikimedia.org/r/634778

@Esanders notes: the JS will only work on wikis that do not have DiscussionTool enabled in any way (e.g. it can not be enabled as a Beta Feature or an opt-out user preference).

@Esanders notes: the JS will only work on wikis that do not have DiscussionTool enabled in any way (e.g. it can not be enabled as a Beta Feature or an opt-out user preference).

This seems to be working as evidenced by having access to the Reply Tool at en.wiki via https://meta.wikimedia.org/wiki/User:PPelberg_(WMF)/global.js.

@Pelagic are you able to check whether you still have access to the Reply Tool at en.wiki via the code snippet [i] you entered into https://en.wikipedia.org/wiki/User:Pelagic/common.js ?

Context
I am asking the above because we recently made a change [ii] that affects how the DiscusionTools javascript hack works.


i.

if ( $( '#ca-addsection' ).length ) mw.loader.using( 'ext.discussionTools.init' );

ii. T252555

WFM on en.wiki

WFM on en.wiki

Roger that. I'm going to leave this open until Wednesday, 28-Oct.

JTannerWMF closed this task as Resolved.Oct 28 2020, 5:16 PM