Page MenuHomePhabricator

Cannot diff content types other than MassMessageListContent
Open, Needs TriagePublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.36.0-wmf.13

message
Cannot diff content types other than MassMessageListContent

Impact

Easily reproducible exception from a GET request

Notes

Details

Request ID
140272dc-c1a6-4a3b-b1ba-63a9ad807c1c
Request URL
https://www.mediawiki.org/?diff=2234116
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.36.0-wmf.13/includes/diff/DifferenceEngineSlotDiffRenderer.php(54): MediaWiki\MassMessage\Content\MassMessageListDiffEngine->generateContentDiffBody(WikitextContent, MediaWiki\MassMessage\Content\MassMessageListContent)
#1 /srv/mediawiki/php-1.36.0-wmf.13/includes/diff/DifferenceEngine.php(1246): DifferenceEngineSlotDiffRenderer->getDiff(WikitextContent, MediaWiki\MassMessage\Content\MassMessageListContent)
#2 /srv/mediawiki/php-1.36.0-wmf.13/includes/diff/DifferenceEngine.php(1151): DifferenceEngine->getDiffBody()
#3 /srv/mediawiki/php-1.36.0-wmf.13/includes/diff/DifferenceEngine.php(1113): DifferenceEngine->getDiff(string, string, string)
#4 /srv/mediawiki/php-1.36.0-wmf.13/includes/diff/DifferenceEngine.php(877): DifferenceEngine->showDiff(string, string, string)
#5 /srv/mediawiki/php-1.36.0-wmf.13/includes/page/Article.php(984): DifferenceEngine->showDiffPage(boolean)
#6 /srv/mediawiki/php-1.36.0-wmf.13/includes/page/Article.php(660): Article->showDiffPage()
#7 /srv/mediawiki/php-1.36.0-wmf.13/includes/actions/ViewAction.php(74): Article->view()
#8 /srv/mediawiki/php-1.36.0-wmf.13/includes/MediaWiki.php(527): ViewAction->show()
#9 /srv/mediawiki/php-1.36.0-wmf.13/includes/MediaWiki.php(313): MediaWiki->performAction(Article, Title)
#10 /srv/mediawiki/php-1.36.0-wmf.13/includes/MediaWiki.php(940): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.36.0-wmf.13/includes/MediaWiki.php(543): MediaWiki->main()
#12 /srv/mediawiki/php-1.36.0-wmf.13/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-1.36.0-wmf.13/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2020, 6:45 PM
Ammarpad added a subscriber: Ammarpad.EditedOct 21 2020, 10:00 AM

Intentionally thrown by extension: includes/Content/MassMessageListDiffEngine.php#29 because it doesn't want diff wikitext content and massmessage content. But such diffing here is actually possible, because both content are subcontents of TextContent.

See also T231084 where also two different contens are diffed (but one is not text), but it shows the same problem as here: It is possible to diff wikitext with masscontent, but not masscontent with wikitext

Broken:
https://www.mediawiki.org/w/index.php?title=User:Quiddity/demomodel&diff=2234116&oldid=2234115
Swapped:
https://www.mediawiki.org/w/index.php?title=User:Quiddity/demomodel&diff=2234115&oldid=2234116