Page MenuHomePhabricator
Create Task
Maniphest T265539

Add soft dependencies of the Cosmos skin to CI jobs
Closed, ResolvedPublic
Actions

Description

The code review for converting Cosmos to be properly namespaced was done as part of T265107. However, there had to be a follow-up patch in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Cosmos/+/633763 as a use statement was accidentally missed. This was missed since I didn't have any of the extensions that Cosmos integrates with installed, and that static call to SpecialPage only gets run when CreateRedirect extension is installed at the same time.

To mitigate this, we should add a patch to integration-config repository to also install the following extensions whenever it runs CI jobs for Cosmos:

  • AdminLinks
  • CreateRedirect
  • DismissableSiteNotice
  • Echo
  • ManageWiki
  • SocialProfile
  • VisualEditor

Details

ProjectBranchLines +/-Subject
integration/configmaster+4 -2Zuul: [mediawiki/skins/Cosmos] Add soft dependencies to CI jobs
Customize query in gerrit

Related Objects

Event Timeline

SamanthaNguyen created this task.Oct 14 2020, 7:55 PM
SamanthaNguyen added a subscriber: hashar.

@Universal_Omega Do you want to work on this? I can help show you how to make a patch to integration-config.

SamanthaNguyen mentioned this in T265537: Document process on how to contribute to the Cosmos skin.Oct 14 2020, 8:00 PM
SamanthaNguyen added a comment.Oct 15 2020, 12:03 AM

Just discussed, adding ManageWiki as a soft dependency will probably need a separate task as it requires more setup (since it was created for the Miraheze wiki platform). The rest should be fine.

SamanthaNguyen added a comment.EditedOct 15 2020, 7:34 PM

@Universal_Omega See https://github.com/wikimedia/integration-config/blob/master/zuul/parameter_functions.py#L141 for how it currently works

gerritbot added a comment.Oct 15 2020, 8:14 PM

Change 634261 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[integration/config@master] Add soft dependencies of the Cosmos skin to CI jobs

https://gerrit.wikimedia.org/r/634261

gerritbot added a project: Patch-For-Review.Oct 15 2020, 8:14 PM
Universal_Omega claimed this task.Oct 15 2020, 8:50 PM
Universal_Omega triaged this task as Medium priority.
Universal_Omega moved this task from Incoming / Backlog to In Progress on the Cosmos board.
gerritbot added a comment.Oct 16 2020, 7:24 PM

Change 634261 merged by jenkins-bot:
[integration/config@master] Zuul: [mediawiki/skins/Cosmos] Add soft dependencies to CI jobs

https://gerrit.wikimedia.org/r/634261

Stashbot added a comment.Oct 16 2020, 7:25 PM

Mentioned in SAL (#wikimedia-releng) [2020-10-16T19:25:03Z] <James_F> Zuul: [mediawiki/skins/Cosmos] Add soft dependencies to CI jobs T265539

Jdforrester-WMF closed this task as Resolved.Oct 16 2020, 7:26 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

This is now deployed. If you have any issues, please shout.

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 8:10 PM
SamanthaNguyen moved this task from In Progress to Done on the Cosmos board.Oct 17 2020, 3:34 PM
SamanthaNguyen mentioned this in T265807: CI failures related to SocialProfile affecting other repositories for patches being submitted on the REL1_34 and REL1_35 branch, but not master.Oct 17 2020, 9:50 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL