The class SpecialEmailUser provide static functions to share code with api modules
This makes service injection hard
Functions seems to be SpecialEmailUser::getTarget, SpecialEmailUser::validateTarget and SpecialEmailUser::getPermissionsError
https://codesearch.wmcloud.org/search/?q=SpecialEmailUser&i=nope&files=&repos=
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | None | T348042 [EPIC] Feature Improvements to Email Participants | |||
| Open | None | T346968 [EPIC] Feature Improvements to Email Participants | |||
| Resolved | Daimona | T348043 Add footer text to emails from organizers | |||
| Open | None | T339821 Update CampaignsUserMailer to use core's EmailUser when available | |||
| Open | None | T259960 Inject services into API modules and special pages | |||
| Open | None | T265541 Make class SpecialEmailUser a real special page and move all helper functions to their own service |
Change 675874 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] Add basic EmailUserUtils service
Change 675876 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] Clean up and simplify SpecialEmailUser::submit
Change 675876 merged by jenkins-bot:
[mediawiki/core@master] Clean up and simplify SpecialEmailUser::submit
I would like to move this forward. @DannyS712 are you planning to work on the patch above, or can I take it over?
Have at it, sorry I have a lot less time than I used to for wiki contributions. Feel free to add me as a reviewer to the patch though
Change 896374 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] Move email business logic from SpecialEmailUser to a new class
Change 896422 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] Round 1 of EmailUser refactoring
Change 896459 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] Round 2 of EmailUser refactoring
Change 896670 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] [WIP] Round 3 of EmailUser refactoring
Change 896374 merged by jenkins-bot:
[mediawiki/core@master] mail: Move SpecialEmailUser business logic to a new class
Change 897880 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] mail: Make EmailUser::getPermissionsError() return StatusValue
Change 898835 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] mail: Round 4 of EmailUser refactoring
Change 675874 abandoned by DannyS712:
[mediawiki/core@master] Add basic EmailUserUtils service
Reason:
Change 896422 merged by jenkins-bot:
[mediawiki/core@master] mail: Round 1 of EmailUser refactoring
Change 896459 merged by jenkins-bot:
[mediawiki/core@master] mail: Round 2 of EmailUser refactoring
Change 896670 merged by jenkins-bot:
[mediawiki/core@master] mail: Round 3 of EmailUser refactoring
Change 921367 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] Use EmailUser in User::canSendEmail, deprecate EmailUserPermissionsErrorsHook
Change 897880 merged by jenkins-bot:
[mediawiki/core@master] mail: Make EmailUser::getPermissionsError() return StatusValue
Change 898835 merged by jenkins-bot:
[mediawiki/core@master] mail: Round 4 of EmailUser refactoring
Change 921367 merged by jenkins-bot:
[mediawiki/core@master] Use EmailUser in User::canSendEmail, deprecate EmailUserPermissionsErrorsHook
Change 921702 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/extensions/TorBlock@master] Replace EmailUserPermissionsErrors hook with UserCanSendEmail
Change 921761 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] mail: Round 5 of EmailUser refactoring
Change 922129 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] Introduce EmailUserFactory
Change 922140 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] mail: Round 6 of EmailUser refactoring
Change 922549 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] mail: Final round of EmailUser refactoring
Change 922825 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/core@master] Make EmailUserPermissionsErrorsHook emit deprecation errors
Change 921702 merged by jenkins-bot:
[mediawiki/extensions/TorBlock@master] Replace EmailUserPermissionsErrors hook with UserCanSendEmail
Change 922825 merged by jenkins-bot:
[mediawiki/core@master] Make EmailUserPermissionsErrorsHook emit deprecation errors
Change 921761 merged by jenkins-bot:
[mediawiki/core@master] mail: Round 5 of EmailUser refactoring
Change 922129 merged by jenkins-bot:
[mediawiki/core@master] Introduce EmailUserFactory
Change 922140 merged by jenkins-bot:
[mediawiki/core@master] mail: Round 6 of EmailUser refactoring
Change 922549 merged by jenkins-bot:
[mediawiki/core@master] mail: Final round of EmailUser refactoring
Change 957969 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] Make EmailUser stable, deprecated old methods
Change 957969 merged by jenkins-bot:
[mediawiki/core@master] Make EmailUser stable, deprecate old methods
This is almost done now. The main thing that's left to do is a replacement for ::getTarget(). I'm still not 100% sure of what it should look like. r676595 is an attempt.
Change 676595 had a related patch set uploaded (by Daimona Eaytoy; author: Ppchelko):
[mediawiki/core@master] Introduce a lookup for UserEmailContact
Change #1023063 had a related patch set uploaded (by Majavah; author: Majavah):
[mediawiki/extensions/CampaignEvents@master] Use EmailUser class for permission checking
Change #1023063 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Use EmailUser class for permission checking
I'm not actively working on this, but would like to do this eventually. Ideas on how to move forward are welcome!