Deprecate $options['specIsArg'] in favor of $spec['spec_is_arg']
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Oct 14 2020, 11:26 PM

Description

$options['specIsArg'] is documented as

If set and truthy, default $spec['spec_is_arg'] = true if it is unset. This is mainly intended for backwards compatibility with existing code that uses a near-clone of ObjectFactory with those semantics.

However, this is only used in a single place, the construction of FileJournal objects. I suggest deprecating this functionality

Codesearch: https://codesearch.wmcloud.org/search/?q=specIsArg&i=nope&files=&repos=

Details

	Subject	Repo	Branch	Lines +/-
	[BREAKING CHANGE] drop `specIsArg` option	mediawiki/libs/ObjectFactory	master	+5 -11
	FileJournal: use spec_is_arg in ObjectFactory specs	mediawiki/core	master	+10 -6

Customize query in gerrit

Event Timeline

DannyS712 created this task.Oct 14 2020, 11:26 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 14 2020, 11:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 634091 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] FileJournal: use spec_is_arg in ObjectFactory specs

https://gerrit.wikimedia.org/r/634091

gerritbot added a project: Patch-For-Review.Oct 14 2020, 11:27 PM

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Oct 14 2020, 11:30 PM

DannyS712 updated the task description. (Show Details)

DannyS712 triaged this task as Medium priority.Oct 14 2020, 11:59 PM

DannyS712 added a project: Platform Team Workboards (External Code Reviews).

Can this be closed as invalid?

Change 634091 abandoned by DannyS712:

[mediawiki/core@master] FileJournal: use spec_is_arg in ObjectFactory specs

Reason:

no longer needed

https://gerrit.wikimedia.org/r/634091