Page MenuHomePhabricator

Identify which extensions' tests make HTTP requests and so are now broken post-T262443
Open, Unbreak Now!Public

Description

mediawiki/extensions/Math/+/634038 failed to merge with error message HTTP request blocked. Use MockHttpTrait.

Example:

+'<strong class="error texerror">Failed to parse (Conversion error. Server (&quot;https://wikimedia.org/api/rest_&quot;) reported: &quot;HTTP request blocked. Use MockHttpTrait.&quot;): {\displaystyle e^{i \pi} + 1 = 0\,\!}</strong>\n

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/41299/consoleFull

Caused by T262443: Do not hit actual urls during phpunit tests

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Oct 15, 3:43 PM
zeljkofilipin triaged this task as High priority.Thu, Oct 15, 3:43 PM
zeljkofilipin moved this task from Backlog 🔙 to Waiting... 🐌 on the User-zeljkofilipin board.
Reedy updated the task description. (Show Details)Thu, Oct 15, 4:46 PM

Change 634293 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/UploadWizard@master] ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests

https://gerrit.wikimedia.org/r/634293

Change 634294 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/UploadWizard@master] Skip ApiFlickrBlacklistTest tests

https://gerrit.wikimedia.org/r/634294

Change 634294 abandoned by Jforrester:
[mediawiki/extensions/UploadWizard@master] Skip ApiFlickrBlacklistTest tests

Reason:
Let's go with mine?

https://gerrit.wikimedia.org/r/634294

Change 634305 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Math@master] MathCoverageTest: Skip all tests for now as HTTP requests are banned

https://gerrit.wikimedia.org/r/634305

Change 634293 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests

https://gerrit.wikimedia.org/r/634293

Change 634259 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/UploadWizard@wmf/1.36.0-wmf.13] ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests

https://gerrit.wikimedia.org/r/634259

Jdforrester-WMF renamed this task from HTTP request blocked. Use MockHttpTrait. to Identify which extensions' tests make HTTP requests and so are now broken post-T262443.Thu, Oct 15, 6:04 PM
Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.
matmarex removed a subscriber: matmarex.Thu, Oct 15, 6:08 PM

Change 634259 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@wmf/1.36.0-wmf.13] ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests

https://gerrit.wikimedia.org/r/634259

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Tagging Platform for visibility as it's their change that is at the centre of this.