The tests should be rewritten to either disable sending actual HTTP requests, or to provide appropriate expectations to MockHttpClient.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | daniel | T262443 Do not hit actual urls during phpunit tests | |||
| Resolved | • Pchelolo | T265663 EventBus tests are failing as they are hitting actual HTTP |
Event Timeline
Comment Actions
Actually, this is a more interesting issue. If EventBus extension is enabled while running tests, ALL tests start failing - the hooks get executed, the events are being created and they are being sent to a default event service which sends it to default localhost:3000... I guess EventBus extension should not start sending events to a random port when installed but not configured.
Comment Actions
Change 634340 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EventBus@master] Do not send events to actual HTTP with default config
Comment Actions
Change 634340 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Do not send events to actual HTTP with default config
Comment Actions
Change 651607 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[mediawiki/vagrant@master] Enable EventBus to produce all event types
Comment Actions
Change 651607 merged by jenkins-bot:
[mediawiki/vagrant@master] Enable EventBus to produce all event types