Page MenuHomePhabricator

EventBus tests are failing as they are hitting actual HTTP
Closed, ResolvedPublic

Description

The tests should be rewritten to either disable sending actual HTTP requests, or to provide appropriate expectations to MockHttpClient.

Event Timeline

Pchelolo created this task.Oct 15 2020, 8:38 PM
Restricted Application added a project: Analytics. · View Herald TranscriptOct 15 2020, 8:38 PM

Actually, this is a more interesting issue. If EventBus extension is enabled while running tests, ALL tests start failing - the hooks get executed, the events are being created and they are being sent to a default event service which sends it to default localhost:3000... I guess EventBus extension should not start sending events to a random port when installed but not configured.

Change 634340 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EventBus@master] Do not send events to actual HTTP with default config

https://gerrit.wikimedia.org/r/634340

Change 634340 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Do not send events to actual HTTP with default config

https://gerrit.wikimedia.org/r/634340

Pchelolo closed this task as Resolved.Oct 18 2020, 11:44 PM
Pchelolo claimed this task.

Change 651607 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[mediawiki/vagrant@master] Enable EventBus to produce all event types

https://gerrit.wikimedia.org/r/651607

Change 651607 merged by jenkins-bot:
[mediawiki/vagrant@master] Enable EventBus to produce all event types

https://gerrit.wikimedia.org/r/651607