Page MenuHomePhabricator

Wikisource Export: WSexport fails with non helpful error with invalid langs that trigger a redirection
Closed, ResolvedPublic

Description

As a Wikisource user, I want WS-Export to handle errors and incorrect information more gracefully, so I do have a confusing or discouraging experience.

See: https://wsexport.wmflabs.org/book.php?lang=aa&page=Strange_Case_of_Dr_Jekyll_and_Mr_Hyde&format=epub-3&fonts=freeserif

Acceptance Criteria:

  • Fix issue of incorrect language code by either:
    • More gracefully failing (such as message in visual example #1)
    • Change language code selection to a dropdown that can interact with other fields

Visual example #1: error page:

Screen Shot 2020-10-22 at 12.43.45 PM.png (614×1 px, 202 KB)

Visual example #2: a better error (when incorrect name for title entered):

Screen Shot 2020-10-22 at 12.43.37 PM.png (614×1 px, 65 KB)

Event Timeline

@satdeep_gill & I have discussed this, and we have talked about the fact that:

  • This error message is definitely confusing, and it should be fixed
  • We may want to also improve the WS-Export experience in general, so the language code is a dropdown (rather than manually entered) and only titles for relevant language are available to enter
ifried renamed this task from WSexport fails with non helpful error with invalid langs that trigger a redirection to Wikisource Export: WSexport fails with non helpful error with invalid langs that trigger a redirection.Oct 22 2020, 4:46 PM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)

This is the error message we are now seeing (see screenshot example below) for the link provided in the description.

Screen Shot 2021-02-05 at 12.17.40 PM.png (590×1 px, 75 KB)

This is much more helpful since it specifically explains the error to the user, while still displaying the WS-Export user interface. For this reason, this issue now seems to be in a better place and is perhaps eligible to be resolved. @satdeep_gill & @dom_walden What do you think?

This is much more helpful since it specifically explains the error to the user, while still displaying the WS-Export user interface. For this reason, this issue now seems to be in a better place and is perhaps eligible to be resolved. @satdeep_gill & @dom_walden What do you think?

It looks good to me.

  • We may want to also improve the WS-Export experience in general, so the language code is a dropdown (rather than manually entered) and only titles for relevant language are available to enter

Is this what you were thinking about? T269344

ifried claimed this task.

Yup, exactly: T269344 is what I mean, @dom_walden.

I'll mark this ticket as Resolved and we can look into T269344 separately. Thanks!