Page MenuHomePhabricator

Detect invalid IP addresses instead of crashing
Closed, ResolvedPublic

Description

In order to avoid crashes like these:

WARNING: API error param_ip: IP parameter is not valid.
Traceback (most recent call last):
  File "cli.py", line 115, in <module>
    globals()['cli_' + subparser](**kwargs)
  File "cli.py", line 72, in cli_task
    raise e
  File "cli.py", line 68, in cli_task
    task.run()
  File "/mnt/nfs/labstore-secondary-tools-project/majavah-bot/www/python/src/majavahbot/tasks/task_5_steward_request_bot.py", line 97, in$    steward = self.get_steward_who_gblocked_ip(api, ip)
  File "/mnt/nfs/labstore-secondary-tools-project/majavah-bot/www/python/src/majavahbot/tasks/task_5_steward_request_bot.py", line 19, in$    bgip=ip_or_range,
  File "/data/project/shared/pywikibot/core/pywikibot/data/api.py", line 2078, in submit
    raise APIError(**result['error'])
pywikibot.data.api.APIError: param_ip: IP parameter is not valid.
[help: See https://meta.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.$CRITICAL: Exiting due to uncaught exception <class 'pywikibot.data.api.APIError'>

Instead of crashing the whole run, the bot should catch those failures and add a comment or something similar

Event Timeline

taavi triaged this task as Medium priority.Oct 16 2020, 1:19 PM
taavi created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript