Page MenuHomePhabricator

Please support dealerdirect/phpcodesniffer-composer-installer
Closed, ResolvedPublic

Description

dealerdirect/phpcodesniffer-composer-installer is a commonly used composer plugin to make it easy to import phpcs standards via composer.

For that plugin to be able to recognize mediawiki/mediawiki-codesniffer as being a package containing phpcs standards, composer.json needs to declare the type as being "phpcodesniffer-standard".

The change needed is very simple:

diff --git a/composer.json b/composer.json
index c24cc68..66cc3bf 100644
--- a/composer.json
+++ b/composer.json
@@ -7,6 +7,7 @@
        ],
        "homepage": "https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP",
        "license": "GPL-2.0-or-later",
+       "type": "phpcodesniffer-standard",
        "require": {
                "php": ">=7.2.0",
                "ext-mbstring": "*",

I'd submit that to Gerrit myself, but my Gerrit account seems to be non-functional.

Event Timeline

Change 634515 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/tools/codesniffer@master] composer.json - declare type phpcodesniffer-standard

https://gerrit.wikimedia.org/r/634515

Didn't look into how this works / what composer.json's type does, but patch sent

Change 634515 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] composer.json - declare type phpcodesniffer-standard

https://gerrit.wikimedia.org/r/634515

Reedy assigned this task to DannyS712.