Page MenuHomePhabricator

.mw-indicators in Modern skin displaying vertically/improperly
Closed, ResolvedPublic

Description

See e.g. https://en.wikipedia.org/wiki/Earth?useskin=modern (or https://en.wikipedia.org/wiki/Earth?useskin=modern&safemode=true if you like). Where previously the icons on the upper right ("topicons") would display horizontally, they are now rendered vertically, with some hidden by #p-personal. I'm not sure exactly what changed, but presumably this is from T248751/https://gerrit.wikimedia.org/r/c/mediawiki/skins/Modern/+/585834 cc @Jdlrobson

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2020, 8:50 PM
Xaosflux added a project: Regression.
Xaosflux added a subscriber: Xaosflux.

Possible hack available:

$('.mw-indicators').children().addClass('mw-indicator')

Change 638180 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Modern@master] Correction to indicator output

https://gerrit.wikimedia.org/r/638180

Izno added a subscriber: Izno.Mon, Nov 2, 10:04 PM

Change 638180 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Correction to indicator output

https://gerrit.wikimedia.org/r/638180

Jdlrobson closed this task as Resolved.Wed, Nov 4, 6:42 PM
Jdlrobson claimed this task.

Will be fixed in next deploy.