No error shown when trying to save lemma with invalid language code
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Nikki
	Oct 17 2020, 1:28 AM

Description

Problem:
No error is shown when trying to save an invalid language code for a Lemma on a Lexeme. We should show an error to give the editor some indication about what's going on.

Steps to reproduce:

Go to https://test.wikidata.org/wiki/Lexeme:L1 and start editing the lemma
Enter "test" as the spelling variant
Press enter or click publish

Expected behaviour: The language code is not valid, so an error should be shown.
Actual behaviour: It briefly looks like it's saving and then it returns to the previous state with no indication of anything having gone wrong.

Screenshots/mockups:
Use the same behaviour that is happening when saving a wrong language variant for a Form

BDD
GIVEN a Lemma on a Lexeme
WHEN saving an invalid language code
THEN an error is shown
AND the edit is not saved
AND edit mode is restored

Acceptance criteria:

error message is shown when trying to save an invalid language code for a Lemma on a Lexeme

Details

Subject	Repo	Branch	Lines +/-
Add term text to UnknownLanguage error message	mediawiki/extensions/WikibaseLexeme	master	+74 -13
Fix error handling in LexemeHeader	mediawiki/extensions/WikibaseLexeme	master	+29 -2
Display error in UI when trying to save a lemma with invalid language code	mediawiki/extensions/WikibaseLexeme	master	+10 -6

Customize query in gerrit

Related Objects

Mentioned In: T271805: Adding whitespace-only lemma makes no edit and shows no error message

Event Timeline

Nikki created this task.Oct 17 2020, 1:28 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 17 2020, 1:28 AM

Lydia_Pintscher added a project: Wikidata-Campsite.Dec 13 2020, 7:59 PM

Lydia_Pintscher updated the task description. (Show Details)

Lydia_Pintscher moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.

Thadguidry subscribed.Dec 13 2020, 8:39 PM

Lydia_Pintscher updated the task description. (Show Details)Dec 14 2020, 2:48 PM

The API request returns an error:

{
  "errors": [
    {
      "code": "not-recognized-language",
      "data": {
        "parameterName": "lemmas",
        "fieldPath": [
          "ja-hirandtrndtrn"
        ]
      },
      "*": "Unknown language \"ja-hirandtrndtrn\" in field \"lemmas\" at \"ja-hirandtrndtrn\"."
    }
  ],
  "servedby": "mw1376",
  "*": "See https://www.wikidata.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&gt; for notice of API deprecations and breaking changes."
}

We “just” need to show it in the UI.

noarave set the point value for this task to 8.Dec 15 2020, 2:27 PM

Lydia_Pintscher moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Dec 15 2020, 2:27 PM

Lydia_Pintscher edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Dec 15 2020, 3:15 PM

noarave moved this task from Wikidata-Campsite-Iteration-∞ (On Hold) to Blocked / Waiting / External on the Wikidata-Campsite board.Dec 16 2020, 9:17 AM

noarave edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).

noarave moved this task from Blocked / Waiting / External to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.

noarave edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

noarave claimed this task.Jan 4 2021, 1:45 PM

Restricted Application added a project: User-Noarave. · View Herald TranscriptJan 4 2021, 1:45 PM

noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 4 2021, 1:46 PM

Change 654817 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/WikibaseLexeme@master] Display error in UI when trying to save a lemma with invalid language code

https://gerrit.wikimedia.org/r/654817

gerritbot added a project: Patch-For-Review.Jan 7 2021, 12:19 PM

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 7 2021, 12:22 PM

Lucas_Werkmeister_WMDE mentioned this in T271805: Adding whitespace-only lemma makes no edit and shows no error message.Jan 12 2021, 12:13 PM

Change 656191 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix error handling in LexemeHeader

https://gerrit.wikimedia.org/r/656191

Change 654817 abandoned by Noa wmde:
[mediawiki/extensions/WikibaseLexeme@master] Display error in UI when trying to save a lemma with invalid language code

Reason:

https://gerrit.wikimedia.org/r/654817

noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 15 2021, 7:23 PM

It seems the patch wasn't merged because of CI. Moving it back to review to get it looked at again.

Change 656191 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix error handling in LexemeHeader

https://gerrit.wikimedia.org/r/656191

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 18 2021, 10:00 AM

noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 18 2021, 10:16 AM

This looks good but the error message is still a bit misleading because it talks about the Lemma and not the spelling variant. We could have a new error message that displays 'Unknown spelling variant xxx for Lemma yyy.' Do you think this is possible?

Not easily, I think, since the whole validation is written in a fairly generic fashion… the same message is used, for instance, for form representations:

But I think we could at least add the term text to the message:

Unknown language "friday" for term "test" in field "lemmas" at "friday".

Would that be an improvement?

Yes, this is better ✨🔥

noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 26 2021, 10:12 AM

Change 661151 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add term text to UnknownLanguage error message

https://gerrit.wikimedia.org/r/661151

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 9 2021, 10:27 AM

Change 661151 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add term text to UnknownLanguage error message

https://gerrit.wikimedia.org/r/661151

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 9 2021, 3:13 PM

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.31; 2021-02-16); removed MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Feb 9 2021, 4:00 PM

\o/

	F34011765: Screenshot_2021-01-22 sandbox いそぐ dog.png
	Jan 22 2021, 11:44 AM

	F34011708: image.png
	Jan 22 2021, 10:15 AM

No error shown when trying to save lemma with invalid language codeClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

No error shown when trying to save lemma with invalid language code
Closed, ResolvedPublic8 Estimated Story Points
Actions