Page MenuHomePhabricator

Weird text overlay in Modern's echo indicators
Open, Needs TriagePublicBUG REPORT

Description

Placing your cursor over the echo indicators in modern now shows the text (ALERTS, NOTIFICATIONS) in faded, overlapping text. Happens regardless of whether there are any messages.

Fallout from T264339: "Notices" hitbox overlaps "alerts"

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2020, 5:41 PM
Amorymeltzer changed the subtype of this task from "Task" to "Bug Report".Oct 18 2020, 5:42 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 18 2020, 5:42 PM

Change 637834 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Modern@master] Notification icons: don't show screen reader text when hovering

https://gerrit.wikimedia.org/r/637834

Demian added a comment.EditedSat, Oct 31, 5:52 PM

I assume this is more fallout from T248751?

This issue is present in REL1_35 branch, before T248751 and even before I fixed the icon size and position, so not caused by that.
The rule I've removed comes from 2014: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Modern/+/348299/5/resources/main.css#b100
so that's not the cause. The issue can be tracked back to this line: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/610180/1/modules/nojs/mw.echo.badge.less#24
Which was necessary as part of the experiments in T264339: "Notices" hitbox overlaps "alerts", therefore this is fallout from the latter task.

Demian moved this task from Incoming to Awaiting Review on the User-Demian board.