Page MenuHomePhabricator
Create Task
Maniphest T265895

Drop support for MW < 1.33
Closed, ResolvedPublic
Actions

Description

Now that 1.35 is released, we only need to maintain support for MW 1.34 and MW 1.35 (and master branch)

It will be good to do this before MLEB 2020.10 release to take advantage of the pre-release testing.

Expected outcome

Code health is slightly improved by removal of code that is no longer necessary.

Outcome

  • Backward compatible code for older versions of MW were removed from the Translate extension.
  • Translate (and by extension MLEB 2020.10 as a whole and beyond) will only support MW >= 1.34
  • Other extension individually will continue to work with older versions of MW.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UniversalLanguageSelectormaster+1 -1Update minimum MW version to 1.34 as per MLEB policy
mediawiki/extensions/Translatemaster+36 -22Remove usage of deprecated MWNamespace
mediawiki/extensions/Translatemaster+9 -11Services: Reduce coupling to MediaWikiServices by binding to ContainerInterface
mediawiki/extensions/Translatemaster+85 -179Remove support for MW <= 1.33
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedKartikMistryT265886 Release MLEB 2020.10
 Resolvedabi_T265895 Drop support for MW < 1.33

Event Timeline

abi_ triaged this task as Medium priority.Oct 19 2020, 12:35 PM
abi_ created this task.
abi_ moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2020-October-December) board.
abi_ added a project: MediaWiki Language Extension Bundle.
gerritbot added a comment.Oct 19 2020, 5:39 PM

Change 635018 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Remove support for MW <= 1.34

https://gerrit.wikimedia.org/r/635018

gerritbot added a project: Patch-For-Review.Oct 19 2020, 5:39 PM
abi_ claimed this task.Oct 19 2020, 6:46 PM
abi_ moved this task from Priority Backlog to In Progress on the Language-Team (Language-2020-October-December) board.

Working on this since we would like to have this for MLEB release

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2020-October-December) board.Oct 20 2020, 9:55 AM
gerritbot added a comment.Oct 20 2020, 10:28 AM

Change 635018 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove support for MW <= 1.33

https://gerrit.wikimedia.org/r/635018

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 20 2020, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 20 2020, 11:10 AM
gerritbot added a comment.Oct 20 2020, 2:44 PM

Change 635273 had a related patch set uploaded (by Abijeet Patro; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Services: Reduce coupling to MediaWikiServices by binding to ContainerInterface

https://gerrit.wikimedia.org/r/635273

gerritbot added a project: Patch-For-Review.Oct 20 2020, 2:44 PM
gerritbot added a comment.Oct 20 2020, 3:06 PM

Change 635273 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Services: Reduce coupling to MediaWikiServices by binding to ContainerInterface

https://gerrit.wikimedia.org/r/635273

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2020, 3:10 PM
• Nikerabbit updated the task description. (Show Details)Oct 21 2020, 11:45 AM
• Nikerabbit updated the task description. (Show Details)Oct 21 2020, 11:49 AM
gerritbot added a comment.Oct 21 2020, 1:07 PM

Change 604245 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Remove usage of deprecated MWNamespace

https://gerrit.wikimedia.org/r/604245

gerritbot added a project: Patch-For-Review.Oct 21 2020, 1:07 PM
abi_ added projects: UniversalLanguageSelector, MediaWiki-extensions-Babel, MediaWiki-extensions-CleanChanges, MediaWiki-extensions-LocalisationUpdate, MediaWiki-extensions-CLDR.Oct 26 2020, 11:09 AM
abi_ updated the task description. (Show Details)
abi_ updated the task description. (Show Details)Oct 26 2020, 11:12 AM
gerritbot added a comment.Oct 26 2020, 11:12 AM

Change 636394 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/UniversalLanguageSelector@master] Update minimum MW version to 1.34 as per MLEB policy

https://gerrit.wikimedia.org/r/636394

gerritbot added a comment.Oct 26 2020, 4:05 PM

Change 604245 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove usage of deprecated MWNamespace

https://gerrit.wikimedia.org/r/604245

abi_ added a comment.Oct 29 2020, 8:36 AM

B/W code from the Translate extension has been cleaned up to support 1.34 and above, and hence by extension, MLEB as a whole also will now only support MW >= 1.34. We decided to not update the code for the other individual extensions to MW >=1.34 only.

abi_ closed this task as Resolved.Oct 29 2020, 8:38 AM
abi_ updated the task description. (Show Details)
abi_ removed projects: MediaWiki-extensions-CLDR, MediaWiki-extensions-LocalisationUpdate, MediaWiki-extensions-CleanChanges, MediaWiki-extensions-Babel, UniversalLanguageSelector.
abi_ moved this task from In Review to Done on the Language-Team (Language-2020-October-December) board.
gerritbot added a comment.Oct 29 2020, 11:11 AM

Change 636394 abandoned by Abijeet Patro:
[mediawiki/extensions/UniversalLanguageSelector@master] Update minimum MW version to 1.34 as per MLEB policy

Reason:
Individual extensions can continue supporting lower versions of MW

https://gerrit.wikimedia.org/r/636394

• Nikerabbit moved this task from Backlog to 2020.10 on the MediaWiki Language Extension Bundle board.Nov 5 2020, 12:28 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL