Page MenuHomePhabricator

Create implicit use of description in content language
Closed, ResolvedPublic

Description

See parent task for details

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2020, 12:56 PM

Is there a description to this task?

Pablo-WMDE updated the task description. (Show Details)Oct 20 2020, 6:51 AM

@Lydia_Pintscher is it okay if the description usage shows up in the page information (action=info) just like a real usage?

Change 635310 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add implicit usage on description in content language

https://gerrit.wikimedia.org/r/635310

@Lydia_Pintscher is it okay if the description usage shows up in the page information (action=info) just like a real usage?

Answered elsewhere: yes, that’s okay.

Note that the implementation in my current change will also cause the client page to be rerendered (purged) if the description changes, because the part that determines which pages need purging also sees it as a usage like any other.

toan added a subscriber: toan.EditedWed, Oct 28, 10:46 AM

I tried this out locally and it seems to do what we want so I've +2ed both patches! Should we move this back to "todo" to enable the setting and try it out on the test system?

Change 635310 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add implicit usage on description in content language

https://gerrit.wikimedia.org/r/635310

toan added a comment.Wed, Oct 28, 12:50 PM

Moving this back to TODO as we should now enable and test it.

Change 636938 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix keys in ImplicitDescriptionUsageLookup::getUsagesForPage

https://gerrit.wikimedia.org/r/636938

Change 636938 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix keys in ImplicitDescriptionUsageLookup::getUsagesForPage

https://gerrit.wikimedia.org/r/636938

Lucas_Werkmeister_WMDE closed this task as Resolved.Wed, Nov 11, 4:29 PM
Lucas_Werkmeister_WMDE claimed this task.

Moving this back to TODO as we should now enable and test it.

I created T267745: Enable implicit description use in production for that, I think it’s better to mark this task as done.