Page MenuHomePhabricator
Create Task
Maniphest T265915

Active quiet buttons miss border
Closed, ResolvedPublic
Actions

Description

Unlike current implementation in OOUI v0.40.4, quiet buttons in active state should feature a border according to Design Style Guide.
This would also result in a less jarring transition between active and focus state.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+804 -213Update OOUI to v0.41.0
oojs/uimaster+49 -67ButtonElement: Clean up and simplify `:active` state
wvuimaster+32 -28[components][button] Fix button borders
Customize query in gerrit

Event Timeline

Volker_E created this task.Oct 19 2020, 3:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2020, 3:32 PM
gerritbot added a comment.Oct 25 2020, 6:37 PM

Change 636182 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] ButtonElement: Clean up and simplify :active state

https://gerrit.wikimedia.org/r/636182

gerritbot added a project: Patch-For-Review.Oct 25 2020, 6:37 PM
gerritbot added a comment.Oct 26 2020, 11:04 AM

Change 636393 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[wvui@master] [components][button] Fix button borders

https://gerrit.wikimedia.org/r/636393

gerritbot added a comment.Oct 26 2020, 1:33 PM

Change 636393 merged by jenkins-bot:
[wvui@master] [components][button] Fix button borders

https://gerrit.wikimedia.org/r/636393

Volker_E moved this task from Backlog to Reviewing on the WVUI board.Oct 26 2020, 6:22 PM
gerritbot added a comment.Oct 28 2020, 12:11 AM

Change 636182 merged by jenkins-bot:
[oojs/ui@master] ButtonElement: Clean up and simplify :active state

https://gerrit.wikimedia.org/r/636182

Maintenance_bot removed a project: Patch-For-Review.Oct 28 2020, 1:10 AM
Volker_E closed this task as Resolved.Nov 9 2020, 7:35 PM
Volker_E claimed this task.
gerritbot added a comment.Dec 3 2020, 9:48 PM

Change 645179 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.41.0

https://gerrit.wikimedia.org/r/645179

gerritbot added a project: Patch-For-Review.Dec 3 2020, 9:48 PM
gerritbot added a comment.Dec 4 2020, 5:41 PM

Change 645179 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.41.0

https://gerrit.wikimedia.org/r/645179

Maintenance_bot removed a project: Patch-For-Review.Dec 4 2020, 6:10 PM
Volker_E triaged this task as Medium priority.Jan 14 2021, 11:52 AM
Volker_E moved this task from Backlog to Done on the Wikimedia Design Style Guide board.
Volker_E moved this task from Reviewing to Done on the WVUI board.Feb 1 2021, 4:45 PM
Volker_E moved this task from Backlog to OOUI-0.41.0 on the OOUI board.Mar 14 2021, 7:40 PM
Volker_E edited projects, added OOUI (OOUI-0.41.0); removed OOUI.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL