Consistent hover effects on user, search, and notification icons
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	apaskulin
	Oct 19 2020, 9:05 PM

Description

Expected behavior

User, search, and notification icons have a hover-activated highlight box that is a consistent size and orientation.

Observed behavior

At narrower widths, the user icon has a long, rectangular highlight box, while the search and notification icons have smaller, square boxes.
The notification icon is not perfectly centered within the highlight box.

Screen Shot 2020-10-19 at 10.19.20 AM.png (74×150 px, 3 KB)

Screen Shot 2020-10-19 at 10.19.00 AM.png (61×101 px, 2 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Hover effects on icons: consistent hover effects on user, search, and notification icons	mediawiki/skins/WikimediaApiPortal	master	+6 -6
	styles: Attempt to fix inconsistent hover boxes	mediawiki/skins/WikimediaApiPortal	master	+8 -2

Customize query in gerrit

Event Timeline

apaskulin created this task.Oct 19 2020, 9:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2020, 9:05 PM

apaskulin triaged this task as Low priority.Oct 19 2020, 9:06 PM

Change 635093 had a related patch set uploaded (by Alex Paskulin; owner: Alex Paskulin):
[mediawiki/skins/WikimediaApiPortal@master] styles: Attempt to fix inconsistent hover boxes

https://gerrit.wikimedia.org/r/635093

gerritbot added a project: Patch-For-Review.Oct 19 2020, 10:12 PM

apaskulin moved this task from Backlog to Ready for S&F on the WikimediaApiPortal board.Oct 20 2020, 3:06 PM

apaskulin raised the priority of this task from Low to Medium.Oct 23 2020, 5:05 PM

I tried to fix this issue in https://gerrit.wikimedia.org/r/635093 but was unsuccessful. Feel free to use or disregard my attempt.

apaskulin moved this task from Ready for S&F to Validation on the WikimediaApiPortal board.Oct 23 2020, 8:24 PM

Helga_sf moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Oct 26 2020, 4:13 PM

Helga_sf set the point value for this task to 3.Oct 26 2020, 4:16 PM

Vlad.shapik claimed this task.Oct 27 2020, 1:47 PM

Vlad.shapik moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Oct 27 2020, 4:23 PM

Change 637674 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/WikimediaApiPortal@master] Hover effects on icons: consistent hover effects on user, search, and notification icons

https://gerrit.wikimedia.org/r/637674

gerritbot added a project: Patch-For-Review.Oct 30 2020, 10:33 AM

Vlad.shapik moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Oct 30 2020, 10:35 AM

Change 635093 abandoned by Alex Paskulin:
[mediawiki/skins/WikimediaApiPortal@master] styles: Attempt to fix inconsistent hover boxes

Reason:
Abandoning in favor of 637674

https://gerrit.wikimedia.org/r/635093

Change 637674 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Hover effects on icons: consistent hover effects on user, search, and notification icons

https://gerrit.wikimedia.org/r/637674

Vlad.shapik moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.Oct 30 2020, 4:31 PM

Verified on beta. Thanks, Vlad!

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 30 2020, 5:00 PM

	F32399507: Screen Shot 2020-10-19 at 10.19.20 AM.png
	Oct 19 2020, 9:05 PM

	F32399505: Screen Shot 2020-10-19 at 10.19.00 AM.png
	Oct 19 2020, 9:05 PM

Consistent hover effects on user, search, and notification iconsClosed, ResolvedPublic3 Estimated Story PointsActions