Argument 1 passed to ViolationMessageSerializer::serializeEntityId() must be an instance of EntityId, string given
Closed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.13

message

Argument 1 passed to WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageSerializer::serializeEntityId() must be an instance of Wikibase\DataModel\Entity\EntityId, string given

exception.trace

#0 [internal function]: WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageSerializer->serializeEntityId(string)
#1 /srv/mediawiki/php-1.36.0-wmf.13/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/ViolationMessageSerializer.php(111): array_map(array, array)
#2 /srv/mediawiki/php-1.36.0-wmf.13/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/ViolationMessageSerializer.php(73): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageSerializer->serializeEntityIdList(array)
#3 /srv/mediawiki/php-1.36.0-wmf.13/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/ViolationMessageSerializer.php(37): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageSerializer->serializeArgument(array)
#4 /srv/mediawiki/php-1.36.0-wmf.13/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Result/CheckResultSerializer.php(102): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageSerializer->serialize(WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessage)
#5 /srv/mediawiki/php-1.36.0-wmf.13/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(300): WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer->serialize(WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult)
#6 /srv/mediawiki/php-1.36.0-wmf.13/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(238): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->storeResults(Wikibase\DataModel\Entity\ItemId, WikibaseQuality\ConstraintReport\ConstraintCheck\Cache\CachedCheckResults)
#7 /srv/mediawiki/php-1.36.0-wmf.13/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(166): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getAndStoreResults(array, array, NULL, array)
#8 /srv/mediawiki/php-1.36.0-wmf.13/extensions/WikibaseQualityConstraints/src/Api/CheckConstraints.php(172): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getResults(array, array, NULL, array)
#9 /srv/mediawiki/php-1.36.0-wmf.13/includes/api/ApiMain.php(1566): WikibaseQuality\ConstraintReport\Api\CheckConstraints->execute()
#10 /srv/mediawiki/php-1.36.0-wmf.13/includes/api/ApiMain.php(546): ApiMain->executeAction()
#11 /srv/mediawiki/php-1.36.0-wmf.13/includes/api/ApiMain.php(517): ApiMain->executeActionWithErrorHandling()
#12 /srv/mediawiki/php-1.36.0-wmf.13/api.php(90): ApiMain->execute()
#13 /srv/mediawiki/php-1.36.0-wmf.13/api.php(45): wfApiMain()
#14 /srv/mediawiki/w/api.php(3): require(string)
#15 {main}

Impact

28 events in the past hour (as of 2020-10-20 13:27 UTC+2), but all at 11:02 and 11:03 UTC

Notes

Details

Request ID: c558481e-2e3d-41b1-8583-3cca8e74759e
Request URL: https://www.wikidata.org/w/api.php?action=wbcheckconstraints&format=json&formatversion=2&uselang=nl&id=Q10035&status=violation%7Cwarning%7Csuggestion%7Cbad-parameters

	Subject	Repo	Branch	Lines +/-
	Fix EntityId vs. string mismatch in ConstraintParameterParser	mediawiki/extensions/WikibaseQualityConstraints	master	+6 -2

Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 20 2020, 11:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2020, 11:23 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 20 2020, 11:27 AM

The error seems to happen for many different entity IDs (according to the request URL and referrer). Nothing obviously suspicious there. (The uselang also varies.)

Krinkle updated the task description. (Show Details)Oct 23 2020, 7:37 PM

Krinkle edited Stack Trace. (Show Details)

Krinkle moved this task from Untriaged to Oct 2020 on the Wikimedia-production-error board.

Change 636726 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix EntityId vs. string mismatch in ConstraintParameterParser

https://gerrit.wikimedia.org/r/636726

gerritbot added a project: Patch-For-Review.Oct 27 2020, 6:00 PM

thiemowmde claimed this task.Oct 27 2020, 6:01 PM

thiemowmde added a project: Unplanned-Sprint-Work.

thiemowmde set the point value for this task to 2.

Change 636726 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix EntityId vs. string mismatch in ConstraintParameterParser

https://gerrit.wikimedia.org/r/636726

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 27 2020, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2020, 7:10 PM

thiemowmde moved this task from incoming to Features/bugs for next release on the Wikibase-Quality-Constraints board.Oct 29 2020, 6:06 AM

thiemowmde added a project: WMDE-QWERTY-Sprint-2020-10-21.

thiemowmde moved this task from Sprint Backlog to Watching on the WMDE-QWERTY-Sprint-2020-10-21 board.