Page MenuHomePhabricator

If stack_trace field is empty log as null value to support filtering
Closed, ResolvedPublic

Description

In logstash there is no way to filter out an empty string.
If the stack_trace is an empty string, it should have a null value.

This will make it much easier to filter out user browser extensions that have no stack trace.

Examples of errors I'd like to filter out:
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.10.22/clienterror/?id=AXVR9aq9LNRtRo5X_GQV
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.10.21/clienterror/?id=AXVL49Up2lgCwKx7sOBL

Event Timeline

Jdlrobson updated the task description. (Show Details)

Change 634295 had a related patch set uploaded (by Jason Linehan; owner: Jason Linehan):
[mediawiki/extensions/WikimediaEvents@master] clientError: Adds new fields and updates behavior.

https://gerrit.wikimedia.org/r/634295

Jdlrobson closed this task as Declined.EditedMar 4 2021, 1:13 AM

We no longer log errors with an empty stack trace as of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/664306

We started filtering out errors without a stack trace in the logstash board by normalized message so I see little reason to log them (which also resolves this)

Jdlrobson changed the task status from Declined to Resolved.Mar 4 2021, 1:14 AM