Page MenuHomePhabricator
Create Task
Maniphest T266065

Stop extending core's SpecialEditWatchlist
Open, MediumPublic
Actions

Description

The class SpecialEditWatchlist is extended in extension, but the class is not part of the stable policy and that does not allow to extend it.

I am not sure what the best way is for the extension

https://codesearch.wmcloud.org/search/?q=extends%5Cs%2BSpecialEditWatchlist%5Cb&i=nope&files=&repos=

TODO

Details

SubjectRepoBranchLines +/-
Redirect Special:EditWatchlist to Special:ReadingListsmediawiki/extensions/MobileFrontendmaster+15 -0
AMC-disabled Watchlist should mirror MobileFrontend versionmediawiki/skins/MinervaNeuemaster+42 -0
Fix importing / Enable viewing of watchlist to everyonemediawiki/extensions/ReadingListsmaster+53 -11
Enable viewing of watchlist to everyonemediawiki/extensions/ReadingListsmaster+28 -6
Show watchlist title when watchlist is visitedmediawiki/extensions/ReadingListsmaster+11 -3
[Proof of concept] Drop the Mobile special pagesmediawiki/extensions/MobileFrontendmaster+18 -2 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Oct 20 2020, 7:24 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 20 2020, 7:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Umherirrender added a parent task: T259960: Inject services into API modules and special pages.Oct 20 2020, 7:24 PM
Jdlrobson added a project: Web-Team-Backlog.Oct 20 2020, 9:53 PM
Jdlrobson subscribed.Oct 23 2020, 5:55 PM

Can we reconsider this in the stable policy at least to relax it for the one exception of MobileFrontend? This has been extended for about 7-8 years now.
I don't think it's in anyone's interest to refactor that code and there is a lot of work to be done to the core version to make the mobile version more friendly.

I'd be very surprised if the Growth team or reading web had capacity to do this.

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Oct 23 2020, 5:55 PM
Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Mar 3 2021, 9:52 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
Umherirrender unsubscribed.Apr 4 2021, 7:51 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.May 4 2021, 9:27 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (Tracking).Sep 16 2021, 4:49 PM
Jdlrobson moved this task from Backlog to Simplify MobileFrontend on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 16 2021, 9:33 PM
Jdlrobson moved this task from Simplify MobileFrontend to [active] Remove Special:MobileContributions on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Dec 9 2021, 5:43 PM
Jdlrobson moved this task from [active] Remove Special:MobileContributions to Remove mobile Watchlist special page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.
Jdlrobson triaged this task as Medium priority.Dec 9 2021, 7:45 PM
gerritbot added a comment.Jan 20 2022, 12:10 AM

Change 755510 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] [Proof of concept] Drop the Mobile special pages

https://gerrit.wikimedia.org/r/755510

gerritbot added a project: Patch-For-Review.Jan 20 2022, 12:10 AM
Jdlrobson added a subtask: T299799: Use JavaScript for updating the items on SpecialEditWatchlist.Jan 21 2022, 8:12 PM
PatchDemoBot added a comment.Jan 26 2022, 12:56 AM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/5b440214c6/w/

PatchDemoBot added a comment.Jan 26 2022, 1:32 AM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/d6efd56b19/w/

PatchDemoBot added a comment.Jan 26 2022, 1:38 AM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d6efd56b19/w/

gerritbot added a comment.Jan 27 2022, 8:29 PM

Change 755510 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] [Proof of concept] Drop the Mobile special pages

Reason:

Not actively working on this. Some of this work will be realized in https://phabricator.wikimedia.org/T300185

https://gerrit.wikimedia.org/r/755510

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2022, 9:10 PM
Etonkovidova closed subtask T299589: Change markup of Watchlist top tabs to support skinning as Resolved.Feb 4 2022, 7:59 PM
Jdlrobson edited projects, added MobileFrontend (MobileFrontend Special Pages); removed MobileFrontend.Mar 4 2022, 10:26 PM
Jdlrobson moved this task from Backlog to EditWatchlist on the MobileFrontend (MobileFrontend Special Pages) board.
PatchDemoBot added a comment.Oct 18 2022, 2:03 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/5b440214c6/w/

Jdlrobson mentioned this in T177260: Rewrite disabled MobileFrontend browser tests to phpunit tests and Node.js browser tests.Dec 13 2023, 10:03 PM
Jdlrobson mentioned this in T263633: Mobile Special:EditWatchlist displays item IDs instead of labels.Dec 13 2023, 10:36 PM
Jdlrobson moved this task from Remove mobile Watchlist special page to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 8 2024, 10:44 PM
gerritbot added a comment.Fri, Mar 22, 8:49 PM

Change #1013602 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ReadingLists@master] Show watchlist title when watchlist is visited

https://gerrit.wikimedia.org/r/1013602

gerritbot added a project: Patch-For-Review.Fri, Mar 22, 8:50 PM

Change #1013603 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Redirect Special:EditWatchlist to Special:ReadingLists

https://gerrit.wikimedia.org/r/1013603

gerritbot added a comment.Fri, Mar 22, 9:02 PM

Change #1013605 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ReadingLists@master] Enable viewing of watchlist to everyone

https://gerrit.wikimedia.org/r/1013605

Jdlrobson moved this task from Future Unplanned to Remove all MobileFrontend special pages on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Fri, Mar 22, 9:06 PM
gerritbot added a comment.Fri, Mar 22, 10:12 PM

Change #1013607 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ReadingLists@master] Fix importing / Enable viewing of watchlist to everyone

https://gerrit.wikimedia.org/r/1013607

gerritbot added a comment.Fri, Mar 22, 10:13 PM

Change #1013605 abandoned by Jdlrobson:

[mediawiki/extensions/ReadingLists@master] Enable viewing of watchlist to everyone

Reason:

Merged into https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ReadingLists/+/1013607?usp=search

https://gerrit.wikimedia.org/r/1013605

Jdlrobson added a comment.Sat, Mar 23, 12:36 AM

Plan:

  1. https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1013600
  2. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1013603
  3. Switch configuration for pilot wikis to use desktop HTML
  4. Switchover to HTML for everyone
  5. Respond to community feedback.
  6. Drop watchlist code and resolve all open technical work for this special page.
gerritbot added a comment.Sat, Mar 23, 12:47 AM

Change #1013607 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Fix importing / Enable viewing of watchlist to everyone

https://gerrit.wikimedia.org/r/1013607

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Sat, Mar 23, 1:00 AM
gerritbot added a comment.Mon, Apr 1, 10:56 PM

Change #1016022 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable desktop watchlist on beta cluster, clean up old references

https://gerrit.wikimedia.org/r/1016022

Jdlrobson updated the task description. (Show Details)Mon, Apr 1, 10:56 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMon, Apr 1, 10:56 PM
Edtadros mentioned this in T360464: Verify 1.42.0-wmf.24 deployment.Thu, Apr 4, 2:55 AM
Jdlrobson updated the task description. (Show Details)Mon, Apr 15, 10:28 PM
gerritbot added a comment.Mon, Apr 15, 10:28 PM

Change #1019934 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] AMC-disabled Watchlist should mirror MobileFrontend version

https://gerrit.wikimedia.org/r/1019934

gerritbot added a comment.Thu, Apr 18, 9:47 PM

Change #1013603 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] Redirect Special:EditWatchlist to Special:ReadingLists

Reason:

I'm considering a new approach with our designer where we link to both ReadingLists and Watchlist, so am going to abandon this for now, until we work that out!

https://gerrit.wikimedia.org/r/1013603

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL