Page MenuHomePhabricator

Echo should unset user-to-user email option when email features are disabled.
Closed, ResolvedPublic

Description

For consistency with core, Echo should check $wgEnableUserEmail and $wgEnableEmail when creating preference options. If either is true, "Email from other user" option should not be provided, as it will not be useful.

I think it's not causing actual problem, but is liable to cause confusion, for example https://www.mediawiki.org/wiki/Topic:Vw4vsqcaoxeidm5q

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 669994 had a related patch set uploaded (by Mech.fandom; owner: Mech.fandom):
[mediawiki/extensions/Echo@master] Unset user-to-user email option when user emails are disabled

https://gerrit.wikimedia.org/r/669994

kostajh claimed this task.
kostajh reassigned this task from kostajh to Mech.fandom.
kostajh added a subscriber: kostajh.

Change 669994 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Unset user-to-user email option when user emails are disabled

https://gerrit.wikimedia.org/r/669994