Echo should unset user-to-user email option when email features are disabled.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ammarpad
	Oct 21 2020, 6:05 AM

Description

For consistency with core, Echo should check $wgEnableUserEmail and $wgEnableEmail when creating preference options. If either is true, "Email from other user" option should not be provided, as it will not be useful.

I think it's not causing actual problem, but is liable to cause confusion, for example https://www.mediawiki.org/wiki/Topic:Vw4vsqcaoxeidm5q

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Unset user-to-user email option when user emails are disabled	mediawiki/extensions/Echo	master	+7 -1

Customize query in gerrit

Event Timeline

Ammarpad created this task.Oct 21 2020, 6:05 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 21 2020, 6:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ammarpad added a project: good first task.Oct 30 2020, 7:08 AM

Change 669994 had a related patch set uploaded (by Mech.fandom; owner: Mech.fandom):
[mediawiki/extensions/Echo@master] Unset user-to-user email option when user emails are disabled

https://gerrit.wikimedia.org/r/669994

gerritbot added a project: Patch-For-Review.Mar 8 2021, 10:09 PM

kostajh closed this task as Resolved.Mar 12 2021, 9:03 AM

kostajh claimed this task.

kostajh reassigned this task from kostajh to Mech.fandom.

kostajh subscribed.

Change 669994 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Unset user-to-user email option when user emails are disabled

https://gerrit.wikimedia.org/r/669994

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2021, 9:48 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 12 2021, 10:00 AM