Page MenuHomePhabricator

Use a caching service in newLanguageIndependentLuaBindings()
Closed, ResolvedPublic

Description

See parent task for details.

Event Timeline

Change 636003 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] wip: use formatter cache in newLanguageIndependentLuaBindings

https://gerrit.wikimedia.org/r/636003

After talking to @hoo about this at the daily we thought it might be a good idea to hold this off until monday and bring @Addshore into the discussion to find the preferred way forward on how we are to solve the problems identified here.

Possible solutions we discussed were

  • not using the formatter cache (which contradicts the AC of the original task)
  • introduce a prefix to the cache keys to avoid the collision between the two (which would mean we could end up caching the same thing but in two different formats)

Seeing that the data already is stored in the cache that's using the language fallback it also feels a bit weird not using that.

Change 636643 had a related patch set uploaded (by Tarrow; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] DNM: Introduce and use Facade for TermFallbackCache

https://gerrit.wikimedia.org/r/636643

Change 636003 abandoned by Tobias Andersson:
[mediawiki/extensions/Wikibase@master] wip: use formatter cache in newLanguageIndependentLuaBindings

Reason:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /636643

https://gerrit.wikimedia.org/r/636003

Change 637524 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Use TermFallbackCacheFacade

https://gerrit.wikimedia.org/r/637524

Change 637525 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Introduce and use CachingFallbackBasedTermLookup

https://gerrit.wikimedia.org/r/637525

Change 637533 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Rename FormatterCache to TermFallbackCache

https://gerrit.wikimedia.org/r/637533

Change 638453 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@WMDEREL_test] Introduce TermFallbackCacheFacade

https://gerrit.wikimedia.org/r/638453

Change 638453 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@WMDEREL_test] Introduce TermFallbackCacheFacade

https://gerrit.wikimedia.org/r/638453

Change 636643 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce TermFallbackCacheFacade

https://gerrit.wikimedia.org/r/636643

Change 640211 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Implement extra CachingFallbackBasedTermLookup methods

https://gerrit.wikimedia.org/r/640211

Change 637524 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use TermFallbackCacheFacade

https://gerrit.wikimedia.org/r/637524

Change 637525 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce and use CachingFallbackBasedTermLookup

https://gerrit.wikimedia.org/r/637525

Change 640211 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Implement extra CachingFallbackBasedTermLookup methods

https://gerrit.wikimedia.org/r/640211

Change 637533 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename FormatterCache to TermFallbackCache

https://gerrit.wikimedia.org/r/637533