Support search filters in no-JS search results page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	egardner
	Oct 21 2020, 3:30 PM

Description

This task is a prerequisite for storing search filters in URL params (T261537), because having filter params implies that they will be recognized immediately if the user was to copy and paste the URL into a new browser or otherwise do a hard refresh. Initial results are fetched on the server and we have no guarantee that users will have JS enabled at all, so search filter URLs must be handled in PHP as well as JS.

Acceptance Criteria

Users who arrive at Special:MediaSearch with valid filter params in the url (like ?q=tree&mimeType=tiff, etc) must get filtered results back from the initial batch of hits, prior to JS initialization
The no-JS UI must provide a way for the user to clear filters that have been set via URL param

Details

	Subject	Repo	Branch	Lines +/-
	Support search filters as URL params in PHP and JS	mediawiki/extensions/WikibaseMediaInfo	master	+459 -48

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		egardner	T261537 [L] Save filter values in URL query params
		Resolved		egardner	T266150 Support search filters in no-JS search results page

Event Timeline

egardner created this task.Oct 21 2020, 3:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2020, 3:30 PM

egardner claimed this task.Oct 21 2020, 3:31 PM

egardner added a parent task: T261537: [L] Save filter values in URL query params.

egardner updated the task description. (Show Details)

CBogen added a project: SDAW-MediaSearch (MediaSearch-ReleaseCandidate).Oct 21 2020, 3:48 PM

CBogen updated the task description. (Show Details)

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.

Change 635644 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] [WIP] Support search filters as URL params in PHP

https://gerrit.wikimedia.org/r/635644

gerritbot added a project: Patch-For-Review.Oct 21 2020, 8:54 PM

egardner moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.Oct 27 2020, 4:12 PM

egardner moved this task from Code Review to Doing on the Structured-Data-Backlog (Current Work) board.Dec 15 2020, 4:40 PM

egardner moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jan 5 2021, 12:01 AM

Change 635644 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Support search filters as URL params in PHP and JS

https://gerrit.wikimedia.org/r/635644

egardner moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 8 2021, 5:02 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2021, 5:10 PM

Moving to @mwilliams for Design review
(1) URL parameters work fine - JS-users and no-JS users with links like this -
https://commons.wikimedia.beta.wmflabs.org/wiki/Special:MediaSearch?q=tree&mimeType=jpeg - will see the filtered results

(2)

The no-JS UI must provide a way for the user to clear filters that have been set via URL param

For example, for the above url - https://commons.wikimedia.beta.wmflabs.org/wiki/Special:MediaSearch?q=tree&mimeType=jpeg - the search results will be displayed as following:

Screen Shot 2021-01-08 at 6.24.23 PM.png (430×880 px, 414 KB)

It looks quite sensible. A user can manually delete the search item and perform a new search, but to delete/modify a file type - that currently can be done only in the url. Is it enough in terms of the UI support for no-JS users?

If all look ok to you - please move the task to Verify in production. I'll do more testing on cross-browser support.

mwilliams moved this task from Design QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jan 13 2021, 4:07 PM

Etonkovidova closed this task as Resolved.Jan 15 2021, 2:37 AM

Etonkovidova updated the task description. (Show Details)Jan 15 2021, 2:40 AM

	F33991274: Screen Shot 2021-01-08 at 6.24.23 PM.png
	Jan 9 2021, 2:39 AM

Support search filters in no-JS search results pageClosed, ResolvedPublicActions