Refactor MentorManager to an abstract class
Closed, ResolvedPublic
Actions

Description

Right now, MentorManager is an interface. I believe it should be an abstract class instead, especially that in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/633776, I introduce MentorManager::getMentors that for all mentor managers I can imagine will just call array_unique(array_merge(MentorManager::getAvailableMentors(), MentorManager::getManuallyAssignedMentors()). This logic will be common to all implementers, so why bother writing it again and again?

Details

	Subject	Repo	Branch	Lines +/-
	Rewrite MentorManager interface to an abstract class	mediawiki/extensions/GrowthExperiments	master	+16 -27

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Urbanecm_WMF	T266189 Refactor MentorManager to an abstract class
		Resolved		Urbanecm_WMF	T245639 Allow anyone to claim a mentee

Event Timeline

Urbanecm_WMF created this task.Oct 21 2020, 9:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2020, 9:48 PM

Urbanecm_WMF claimed this task.Oct 21 2020, 9:48 PM

Urbanecm_WMF added a project: Growth-Team.

Restricted Application added a project: User-Urbanecm_WMF. · View Herald TranscriptOct 21 2020, 9:48 PM

Urbanecm_WMF removed a parent task: T245639: Allow anyone to claim a mentee.Oct 21 2020, 9:49 PM

Urbanecm_WMF added a subtask: T245639: Allow anyone to claim a mentee.

Urbanecm_WMF triaged this task as Lowest priority.Oct 21 2020, 9:52 PM

Urbanecm_WMF moved this task from Untriaged to Engineering on the User-Urbanecm_WMF board.Oct 21 2020, 9:57 PM

Urbanecm_WMF edited projects, added User-Urbanecm_WMF (Engineering); removed User-Urbanecm_WMF.

Urbanecm_WMF moved this task from Backlog to Blocked on the User-Urbanecm_WMF (Engineering) board.

Could also be done with an interface + trait. Nothing wrong with changing it to an abstract class, of course.

Change 636883 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Rewrite MentorManager interface to an abstract class

https://gerrit.wikimedia.org/r/636883

gerritbot added a project: Patch-For-Review.Oct 28 2020, 9:58 AM

Urbanecm_WMF moved this task from Blocked to In review on the User-Urbanecm_WMF (Engineering) board.Oct 28 2020, 9:58 AM

Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr closed this task as Resolved.Oct 29 2020, 4:04 AM

Change 636883 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Rewrite MentorManager interface to an abstract class

https://gerrit.wikimedia.org/r/636883

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 29 2020, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2020, 5:10 AM

MMiller_WMF closed subtask T245639: Allow anyone to claim a mentee as Resolved.Nov 25 2020, 7:15 PM