Page MenuHomePhabricator
Create Task
Maniphest T266248

GeoData extension should not write objects into ExtensionData
Closed, ResolvedPublic
Actions

Description

Instances of PHP classes are not serializable into JSON, so we should not write them into ParserOutput->mExtensionData

Details

SubjectRepoBranchLines +/-
Make extension data JSON-serializable #2 - write JSON.mediawiki/extensions/GeoDatamaster+20 -6
GeoData: Explicitly set coordinates to ParserOutputmediawiki/extensions/Wikibasemaster+8 -0
Make extension data JSON-serializable #1 - forward-compat.mediawiki/extensions/GeoDatamaster+190 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Oct 22 2020, 3:45 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 22 2020, 3:45 PM
• Pchelolo claimed this task.Oct 22 2020, 3:45 PM
JJMC89 removed a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Oct 22 2020, 3:46 PM
• Pchelolo merged a task: T266246: GeoData extension should not write objects into ExtensionData.Oct 22 2020, 3:59 PM
CCicalese_WMF mentioned this in T264394: Ensure content of ParserOutput is safe to serialize.Oct 22 2020, 4:52 PM
gerritbot added a comment.Oct 22 2020, 4:58 PM

Change 635860 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/GeoData@master] Make extension data JSON-serializable #1 - forward-compat.

https://gerrit.wikimedia.org/r/635860

gerritbot added a project: Patch-For-Review.Oct 22 2020, 4:58 PM
gerritbot added a comment.Oct 22 2020, 5:08 PM

Change 635863 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Wikibase@master] GeoData: Explicitly set coordinates to ParserOutput

https://gerrit.wikimedia.org/r/635863

gerritbot added a comment.Oct 22 2020, 5:59 PM

Change 635874 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/GeoData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/635874

• Pchelolo moved this task from Backlog to Waiting for Review on the Platform Team Workboards (Green) board.Oct 22 2020, 6:07 PM
Reedy added a project: GeoData.Oct 22 2020, 11:34 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptOct 22 2020, 11:34 PM
CBogen moved this task from needs triage to Current work on the Discovery-Search board.Oct 26 2020, 4:29 PM
CBogen edited projects, added Discovery-Search (Current work); removed Discovery-Search.
CBogen moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Oct 26 2020, 4:33 PM
• Pchelolo moved this task from Waiting for Review to Ready to Deploy on the Platform Team Workboards (Green) board.Nov 2 2020, 7:29 PM
gerritbot added a comment.Nov 2 2020, 7:30 PM

Change 635860 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Make extension data JSON-serializable #1 - forward-compat.

https://gerrit.wikimedia.org/r/635860

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 2 2020, 8:00 PM
gerritbot added a comment.Nov 2 2020, 9:29 PM

Change 635863 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] GeoData: Explicitly set coordinates to ParserOutput

https://gerrit.wikimedia.org/r/635863

gerritbot added a comment.Nov 10 2020, 1:53 AM

Change 635874 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/635874

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.18; 2020-11-17); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 10 2020, 2:00 AM
• Pchelolo closed this task as Resolved.Nov 18 2020, 8:01 PM
• Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits