Page MenuHomePhabricator

GeoData extension should not write objects into ExtensionData
Closed, ResolvedPublic

Description

Instances of PHP classes are not serializable into JSON, so we should not write them into ParserOutput->mExtensionData

Event Timeline

Pchelolo created this task.Oct 22 2020, 3:45 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 22 2020, 3:45 PM
Pchelolo claimed this task.Oct 22 2020, 3:45 PM

Change 635860 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/GeoData@master] Make extension data JSON-serializable #1 - forward-compat.

https://gerrit.wikimedia.org/r/635860

Change 635863 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Wikibase@master] GeoData: Explicitly set coordinates to ParserOutput

https://gerrit.wikimedia.org/r/635863

Change 635874 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/GeoData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/635874

Restricted Application added a project: Discovery-Search. · View Herald TranscriptOct 22 2020, 11:34 PM

Change 635860 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Make extension data JSON-serializable #1 - forward-compat.

https://gerrit.wikimedia.org/r/635860

Change 635863 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] GeoData: Explicitly set coordinates to ParserOutput

https://gerrit.wikimedia.org/r/635863

Change 635874 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/635874

Pchelolo closed this task as Resolved.Wed, Nov 18, 8:01 PM
Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.