Page MenuHomePhabricator

PageImages extension should not write objects into ExtensionData
Closed, ResolvedPublic

Description

Instances of PHP classes are not serializable into JSON, so we should not write them into ParserOutput->mExtensionData.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2020, 4:24 PM
Pchelolo claimed this task.Oct 22 2020, 6:40 PM

Change 635887 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/PageImages@master] Stop writing objects into ParserOutput::setExtensionData.

https://gerrit.wikimedia.org/r/635887

Change 635887 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Stop writing objects into ParserOutput::setExtensionData.

https://gerrit.wikimedia.org/r/635887

Pchelolo closed this task as Resolved.Tue, Nov 10, 1:20 AM
Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.