PageImages extension should not write objects into ExtensionData
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• CCicalese_WMF
	Oct 22 2020, 4:24 PM

Description

Instances of PHP classes are not serializable into JSON, so we should not write them into ParserOutput->mExtensionData.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Stop writing objects into ParserOutput::setExtensionData.	mediawiki/extensions/PageImages	master	+249 -33

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• Pchelolo	T250500 ParserCache / RESTBase / Parsoid integration
Resolved	daniel	T269034 1.37 Remove support for PHP serialization from ParserCache
Resolved	• Pchelolo	T263579 Change ParserCache serialization format to JSON
Resolved	• Pchelolo	T264394 Ensure content of ParserOutput is safe to serialize
Resolved	• Pchelolo	T266251 PageImages extension should not write objects into ExtensionData

Event Timeline

• CCicalese_WMF created this task.Oct 22 2020, 4:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2020, 4:24 PM

• CCicalese_WMF mentioned this in T264394: Ensure content of ParserOutput is safe to serialize.Oct 22 2020, 4:51 PM

• Pchelolo claimed this task.Oct 22 2020, 6:40 PM

Change 635887 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/PageImages@master] Stop writing objects into ParserOutput::setExtensionData.

https://gerrit.wikimedia.org/r/635887

gerritbot added a project: Patch-For-Review.Oct 22 2020, 8:06 PM

• Pchelolo moved this task from Backlog to Waiting for Review on the Platform Team Workboards (Green) board.Oct 22 2020, 8:19 PM

Jdlrobson added a project: Web-Team-Backlog-Archived (Tracking).Oct 23 2020, 5:40 PM

Change 635887 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Stop writing objects into ParserOutput::setExtensionData.

https://gerrit.wikimedia.org/r/635887

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2020, 12:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 30 2020, 1:00 PM

• Pchelolo moved this task from Waiting for Review to Ready to Deploy on the Platform Team Workboards (Green) board.Oct 30 2020, 1:56 PM

• Pchelolo closed this task as Resolved.Nov 10 2020, 1:20 AM

• Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.