Maniphest T266256

[Design bug] External link icon is missing in reference cards on modal view
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmadeo
	Oct 22 2020, 4:47 PM

Tags

Referenced Files

	F32411233: Screen Shot 2020-10-22 at 2.22.41 PM.png
	Oct 22 2020, 6:34 PM

	F32411232: external.pdf
	Oct 22 2020, 6:34 PM

Subscribers

• MattCleinman

Description

Expected design

Screen Shot 2020-10-22 at 2.22.41 PM.png (630×708 px, 77 KB)

External links should include an indicator that shows that tapping on the link will lead to a site outside of the Wikimedia projects.

External link icon:

external.pdf3 KBDownload

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T241252 Editing Awareness and Trust Experiments
		Resolved		• JMinor	T241253 Experiment: Article as a living document
		Resolved		• JMinor	T257596 UI work in modal
		Resolved		• JMinor	T266256 [Design bug] External link icon is missing in reference cards on modal view

Event Timeline

cmadeo created this task.Oct 22 2020, 4:47 PM

cmadeo updated the task description. (Show Details)Oct 22 2020, 6:34 PM

cmadeo moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Oct 22 2020, 6:48 PM

LGoto triaged this task as Low priority.Oct 22 2020, 7:17 PM

LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.

Notes from sync: external icon should show in all side-scrolling cell links that are external (so for both references cells and snippet cells).

Tsevener moved this task from Needs Acceptance Criteria to Ready for Development on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Oct 22 2020, 7:17 PM

• MattCleinman claimed this task.Nov 9 2020, 10:27 PM

• MattCleinman moved this task from Ready for Development to Doing on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.

• MattCleinman moved this task from Doing to Needs Code Review on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Nov 10 2020, 12:15 AM

Tsevener removed • MattCleinman as the assignee of this task.Nov 16 2020, 9:17 PM

Tsevener moved this task from Needs Code Review to Needs Design Review on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.

@MattCleinman this is looking good! Would it be possible to put 1 pt of space between the link and the external link image? Thanks!

@cmadeo: PR is up - https://github.com/wikimedia/wikipedia-ios/pull/3772/

Tsevener moved this task from Needs Design Review to Waiting for Build on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Nov 18 2020, 7:26 PM

Tsevener moved this task from Waiting for Build to Needs Design Review on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Nov 19 2020, 2:30 AM

• JMinor moved this task from Needs Design Review to Ready for PM Signoff on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Nov 24 2020, 7:19 PM

• JMinor closed this task as Resolved.Dec 8 2020, 9:46 PM

• JMinor claimed this task.