Page MenuHomePhabricator

Kartographer extension should not write objects into ExtensionData
Closed, ResolvedPublic

Description

Instances of PHP classes are not serializable into JSON, so we should not write them into ParserOutput->mExtensionData.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2020, 4:53 PM
daniel claimed this task.Oct 30 2020, 1:01 PM
daniel moved this task from Ready to Doing on the Platform Team Workboards (Green) board.

Change 637691 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Kartographer@master] Make extension data JSON-serializable #1 - forward-compat

https://gerrit.wikimedia.org/r/637691

Change 637692 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Kartographer@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/637692

Change 637691 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Make extension data JSON-serializable #1 - forward-compat

https://gerrit.wikimedia.org/r/637691

Change 637692 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/637692

Pchelolo closed this task as Resolved.Wed, Nov 18, 8:02 PM
Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.