Page MenuHomePhabricator
Create Task
Maniphest T266260

Kartographer extension should not write objects into ExtensionData
Closed, ResolvedPublic
Actions

Description

Instances of PHP classes are not serializable into JSON, so we should not write them into ParserOutput->mExtensionData.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make extension data JSON-serializable #2 - write JSON.mediawiki/extensions/Kartographermaster+3 -4
Make extension data JSON-serializable #1 - forward-compatmediawiki/extensions/Kartographermaster+279 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

• CCicalese_WMF created this task.Oct 22 2020, 4:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2020, 4:53 PM
• CCicalese_WMF mentioned this in T264394: Ensure content of ParserOutput is safe to serialize.Oct 22 2020, 4:54 PM
• Pchelolo moved this task from Backlog to Ready on the Platform Team Workboards (Green) board.Oct 23 2020, 2:09 PM
daniel claimed this task.Oct 30 2020, 1:01 PM
daniel moved this task from Ready to Doing on the Platform Team Workboards (Green) board.
gerritbot added a comment.Oct 30 2020, 1:11 PM

Change 637691 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Kartographer@master] Make extension data JSON-serializable #1 - forward-compat

https://gerrit.wikimedia.org/r/637691

gerritbot added a project: Patch-For-Review.Oct 30 2020, 1:11 PM

Change 637692 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Kartographer@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/637692

• Pchelolo moved this task from Doing to Ready to Deploy on the Platform Team Workboards (Green) board.Nov 2 2020, 6:10 PM
gerritbot added a comment.Nov 2 2020, 6:37 PM

Change 637691 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Make extension data JSON-serializable #1 - forward-compat

https://gerrit.wikimedia.org/r/637691

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 2 2020, 7:00 PM
gerritbot added a comment.Nov 10 2020, 1:45 AM

Change 637692 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Make extension data JSON-serializable #2 - write JSON.

https://gerrit.wikimedia.org/r/637692

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.18; 2020-11-17); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 10 2020, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 10 2020, 2:10 AM
• Pchelolo closed this task as Resolved.Nov 18 2020, 8:02 PM
• Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits