Page MenuHomePhabricator

🐜️​ Application throws an error when processing payment notifications
Open, Needs TriagePublic3 Estimated Story Points

Description

There were some (~30) cases during September in which our application threw an error while processing payment notifications from PayPal:

22-Oct-2020 18:28:36 Europe/Berlin] PHP Fatal error:  Uncaught TypeError: Argument 1 passed to WMDE\Fundraising\PaymentContext\Domain\Model\PayPalData::addChildPayment() must be of the type string, int given, called in /local/sites/spenden.wikimedia.de/release-202010131159/vendor/wmde/fundraising-donations/src/DataAccess/DoctrineDonationRepository.php on line 368 and defined in /local/sites/spenden.wikimedia.de/release-202010131159/vendor/wmde/fundraising-payments/src/Domain/Model/PayPalData.php:201
Stack trace:
#0 /local/sites/spenden.wikimedia.de/release-202010131159/vendor/wmde/fundraising-donations/src/DataAccess/DoctrineDonationRepository.php(368): WMDE\Fundraising\PaymentContext\Domain\Model\PayPalData->addChildPayment()
#1 /local/sites/spenden.wikimedia.de/release-202010131159/vendor/wmde/fundraising-donations/src/DataAccess/DoctrineDonationRepository.php(312): WMDE\Fundraising\DonationContext\DataAccess\DoctrineDonationRepository->getPayPalDataFromEntity()
#2 /local/sites/spenden.wikimedia.de/release-202010131159/vendor/wmde/fundraising-donations/src/Dat in /local/sites/spenden.wikimedia.de/release-202010131159/vendor/wmde/fundraising-payments/src/Domain/Model/PayPalData.php on line 201

I could only check a few of the affected data sets, but the parent data sets all seem to refer to a child transaction ID that consists of digits only (usually they are alphanumeric).

Example data sets:

  • 2762796
  • 3282831

Event Timeline

Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptOct 22 2020, 5:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kai.nissen set the point value for this task to 3.Oct 27 2020, 10:28 AM
AbbanWMDE moved this task from Heap to Doing on the WMDE-FUN-Funban-2020 board.
AbbanWMDE removed AbbanWMDE as the assignee of this task.Oct 28 2020, 4:13 PM
AbbanWMDE moved this task from Doing to Code Review on the WMDE-FUN-Funban-2020 board.
AbbanWMDE added a subscriber: AbbanWMDE.
gabriel-wmde moved this task from Deploy to Done on the WMDE-FUN-Funban-2020 board.Wed, Nov 4, 3:41 PM