Page MenuHomePhabricator

Incorrect "Audio playback is not supported in your browser" error when colon precedes <score> tag
Closed, ResolvedPublic

Description

On FF 81.0.2 I'm told "Audio playback is not supported in your browser. You can download the audio file.", but yet I can play an audio clip perfectly well... I know it's supposed to be alt text...

Screenshot 2020-10-23 at 02.59.38.png (502×1 px, 89 KB)

Obviously can't test this on wikipedia atm.. But that's on my dev wiki where I just enabled Score

Event Timeline

I've encountered the same message on some random pages. Windows 7: Firefox, Chrome, Edge, IE. This has been raised at en:Help talk:Score.

The problem is the indent (colon) before :<score sound="1">.

Aklapper renamed this task from "Audio playback is not supported in your browser. You can download the audio file." - Yes it is? to Incorrect "Audio playback is not supported in your browser" error when colon precedes <score> tag.Aug 22 2021, 8:11 PM

The problem is the indent (colon) before :<score sound="1">.

Confirmed, see https://test.wikipedia.org/wiki/Score/T266307

The Parser or Remex maybe is reordering the nodes so that the fallback text that is supposed to be encompassed in the <audio> tag is being pulled out of it into a separate <div>

https://test.wikipedia.org/api/rest_v1/page/html/Score%2FT266307 shows that Parsoid doesn't mangle it. So, this is not a Remex issue. It is probably doBlockLevels or something in the legacy parser messing with it.

Legoktm added a subscriber: Arlolra.

@Arlolra figured it out a fix, patch incoming.

Change 714651 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/Score@master] Fix score-audio-alt message showing up if <score> preceded by colon

https://gerrit.wikimedia.org/r/714651

Change 714651 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Fix score-audio-alt message showing up if <score> preceded by colon

https://gerrit.wikimedia.org/r/714651

This will be fixed in next week's deployment.

I have the same problem within lists.

I have the same problem within lists.

This is also fixed by the above patch, both lists and colon indents have the same underlying issue in the legacy PHP Parser.