Remove extra space caused by empty subtitle
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	apaskulin
	Oct 23 2020, 4:46 PM

Description

Expected behavior

Page action buttons are directly below titles

Screen Shot 2020-10-23 at 9.45.33 AM.png (97×373 px, 10 KB)

Observed behavior

An empty subtitle div (<div id="contentSub" class="small"></div>) is creating an extra line between titles and page action buttons.

Screen Shot 2020-10-23 at 9.45.22 AM.png (116×359 px, 11 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Functionality and styles of subtitle: remove extra space caused by empty subtitle	mediawiki/skins/WikimediaApiPortal	master	+43 -11
	Functionality and styles of subtitle: remove extra space caused by empty subtitle	mediawiki/skins/WikimediaApiPortal	master	+2 -14

Customize query in gerrit

Event Timeline

apaskulin created this task.Oct 23 2020, 4:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2020, 4:46 PM

apaskulin triaged this task as Low priority.Oct 23 2020, 4:46 PM

apaskulin moved this task from Backlog to Ready for S&F on the WikimediaApiPortal board.Oct 23 2020, 5:03 PM

apaskulin raised the priority of this task from Low to Medium.Oct 23 2020, 5:05 PM

apaskulin added a project: Platform Team Workboards (S&F Workboard).Oct 26 2020, 3:25 PM

Helga_sf moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Oct 26 2020, 4:13 PM

Helga_sf set the point value for this task to 3.

Vlad.shapik claimed this task.Nov 12 2020, 11:26 AM

Vlad.shapik moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.

Change 641175 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/WikimediaApiPortal@master] Functionality and styles of subtitle: remove extra space caused by empty subtitle

https://gerrit.wikimedia.org/r/641175

gerritbot added a project: Patch-For-Review.Nov 16 2020, 2:23 PM

Vlad.shapik moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Nov 16 2020, 2:33 PM

Change 641175 abandoned by Vlad.shapik:
[mediawiki/skins/WikimediaApiPortal@master] Functionality and styles of subtitle: remove extra space caused by empty subtitle

Reason:

https://gerrit.wikimedia.org/r/641175

Change 643280 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/WikimediaApiPortal@master] Functionality and styles of subtitle: remove extra space caused by empty subtitle

https://gerrit.wikimedia.org/r/643280

Change 643280 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Functionality and styles of subtitle: remove extra space caused by empty subtitle

https://gerrit.wikimedia.org/r/643280

Vlad.shapik moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.Nov 24 2020, 7:58 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.20; 2020-12-01).Nov 24 2020, 8:00 PM

Verified on beta. Thanks, Vlad!

	F32411881: Screen Shot 2020-10-23 at 9.45.22 AM.png
	Oct 23 2020, 4:46 PM

	F32411883: Screen Shot 2020-10-23 at 9.45.33 AM.png
	Oct 23 2020, 4:46 PM

Remove extra space caused by empty subtitleClosed, ResolvedPublic3 Estimated Story PointsActions