Some ref error types in embedded content aren't marked up
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	Oct 23 2020, 5:37 PM

Description

The current implementation of keeping pointers to refs, so that, when inserting the references section, we can go back and mark up certain kinds of errors that are only known at that time, doesn't really work for embedded content since we can't keep those pointers live.

A fix could be to instead do a walk of the dom looking for all the refs associated with a specific reference group. That would allow us to peek inside embedded content.

See https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/631860 and https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/635899

Details

Subject	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.13.0-a17	mediawiki/vendor	master	+750 -431
Mark up cite errors in embedded content	mediawiki/services/parsoid	master	+126 -54
Bump wikimedia/parsoid to 0.13.0-a14	mediawiki/vendor	master	+2 K -1 K
Traverse with inEmbeddedContent for ref in ref	mediawiki/services/parsoid	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned In: T202445: Add better testing around ref-in-ref scenarios

Event Timeline

Arlolra created this task.Oct 23 2020, 5:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2020, 5:37 PM

ssastry updated the task description. (Show Details)Oct 23 2020, 5:39 PM

ssastry updated the task description. (Show Details)

Arlolra triaged this task as Medium priority.Oct 23 2020, 6:23 PM

Arlolra moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.

Change 636098 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Traverse with inEmbeddedContent for ref in ref

https://gerrit.wikimedia.org/r/636098

gerritbot added a project: Patch-For-Review.Oct 23 2020, 9:58 PM

Change 636098 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Traverse with inEmbeddedContent for ref in ref

https://gerrit.wikimedia.org/r/636098

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2020, 11:10 PM

Change 638161 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a14

https://gerrit.wikimedia.org/r/638161

gerritbot added a project: Patch-For-Review.Nov 2 2020, 7:14 PM

Change 638161 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a14

https://gerrit.wikimedia.org/r/638161

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 2 2020, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 2 2020, 10:11 PM

Arlolra claimed this task.Nov 5 2020, 4:00 PM

Change 639616 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Mark up cite errors in embedded content

https://gerrit.wikimedia.org/r/639616

gerritbot added a project: Patch-For-Review.Nov 5 2020, 7:46 PM

Change 639616 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Mark up cite errors in embedded content

https://gerrit.wikimedia.org/r/639616

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2020, 12:11 AM

Arlolra closed this task as Resolved.Nov 7 2020, 12:17 AM

Change 641308 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a17

https://gerrit.wikimedia.org/r/641308

gerritbot added a project: Patch-For-Review.Nov 17 2020, 1:09 AM

Change 641308 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a17