Page MenuHomePhabricator

Minerva should use a single ResourceLoader module for shipping its styles
Open, MediumPublic

Description

Minerva has 2 modules for shipping styles - skins.minerva.base.styles, skins.minerva.mainMenu.styles and skins.minerva.content.styles. This is no longer necessary.

Acceptance criteria

  • A new module skins.minerva.styles is the only styles module in Minerva (ignoring icons) and combines the contents of skins.minerva.base.styles, skins.minerva.mainMenu.styles and skins.minerva.content.styles
  • Newly generated HTML will add the skins.minerva.styles module.
  • The three existing modules are marked as deprecated but retained for cached HTML
  • The bundlesize definitions in bundlesize.config.json are updated

Developer notes

For cached HTML the 2 modules are retained for a week referencing the files in the new skin.minerva.styles module.

Sign off steps

  • Check in with apps team in case they are referencing the modules directly (they have been referencing ResourceLoader in the past but shouldn't be any more)

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 23 2020, 6:17 PM
Jdlrobson updated the task description. (Show Details)Oct 23 2020, 6:17 PM
Jdlrobson triaged this task as Medium priority.Oct 26 2020, 6:39 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.