Page MenuHomePhabricator

Article As a Living Doc - followup polish
Open, LowPublic

Description

This is followup polish that came in response to pixel pushing session on https://phabricator.wikimedia.org/T265666. For whatever reason these bugs could not be figured out live, so we need to do a followup to address these:

  1. Navigation bar should have a slight background color on the modal. I was going to try .midBackground but it doesn't seem to respond to any colors I try to give it.
  2. The Close button in the navigation bar on the modal should be the themed link text color. This also seems unresponsive when I try to set it.
  3. Side-scrolling cells do not seem to have any corner radius. The ideal to shoot for is the radius and shadow amount from the On This Day side scrolling cells.
  4. Text in article content slightly shifts when you change themes the first time. This only seems to happen on articles that don't have a header image though, so this one is not a must IMO.

Event Timeline

Tsevener created this task.Oct 23 2020, 7:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2020, 7:49 PM
cmadeo added a subscriber: cmadeo.Oct 26 2020, 4:04 PM

@Tsevener not sure if this is the right spot for this, but I realized I forgot to bring up the 'tap and scroll' behavior on the article view in our session. It'd still be great if tapping on the badge at the top of the article scrolled the reader to the interstitial card.

LGoto triaged this task as Low priority.Oct 26 2020, 6:33 PM
LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.