Page MenuHomePhabricator

Add Link engineering: Edit tag for link recommendations tasks
Closed, ResolvedPublic

Description

Similar to how we have an edit tag for Newcomer Tasks, we want an edit tag specifically for the add link subtype.

  • The user-facing text for the tag should be: "Suggested: add links"
  • The edit should also get the "Newcomer task" tag.
  • The long description should be "Add link" edit suggested by the suggested edits module of the newcomer homepage.
  • The edit tag should apply even if the user makes other changes in the editor outside of the link targets, though this is not going to be possible in the first version of the feature. Users will have to either publish or discard their link additions before using the visual editor on the article.
  • The edit tag should only apply to edits made through our "add links" interface, not other edits made by the user to the selected article. In the future, we may allow users to access this suggested edit task type through routes apart from the feed on the newcomer homepage. The tag should apply in those situations, too.

Event Timeline

Our current logic is to apply the edit tag if the user clicks on the task card and them makes an edit to the article within 7 days.

I assume in this case we do not want that, and want to strictly limit tagging to edits performed through our custom VE interface?

@Tgr -- that is correct. I will update the description.

The edit should not also get the "Newcomer task" tag.

@MMiller_WMF I'm curious about why not. It seems like it should, as it's an edit originating from the same newcomer task flow as the other suggested edits.

Change 640580 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Add Link: Add edit tag

https://gerrit.wikimedia.org/r/640580

@MMiller_WMF there's also a longer description for change tags (shown on Special:Tags which is linked from near the tag name in RecentChanges). Currently that's "Add link" edit suggested by the suggested edits module of the newcomer homepage (vs. Edit suggested by the suggested edits module of the newcomer homepage for the normal newcomer task tag) but maybe you want to provide a different one.

@kostajh -- I only said it should not because I didn't want us to cause tag clutter, like by assigning two tags for the same thing, when it's impossible to infer one from the other. Is tag clutter not a concern? The place that a user would experience the clutter would be on Special:Contributions or Special:RecentChanges. For instance, if you edit from the iOS app, those pages will say the following next to the edit:

image.png (29×281 px, 3 KB)

What do you think? Maybe @Trizek-WMF has advice.

@Tgr -- that long description is fine and I'll add it to the task description.

Change 640580 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add Link: Add edit tag

https://gerrit.wikimedia.org/r/640580

I don't have much about feedback around tags. It is not really a topic in itself apparently.

Of course, a tag displayed in History pages, RCs or in the watchlist should be short and self explanatory. The description is usually only available when people click on the tag list. Also, IIRC, the usage of RCs and Watchlist is limited on mobile: most users have a computer to check such changes, hence some room to display long tags. I don't know about history pages, but they have a specific design on mobile that takes the entire screen for one entry.

"Suggested: add links" is the best option I see to keep it short.

"Newcomers tasks, Suggested: add links" is also possible and probably more explanatory. However, if I translate to other languages, the message may be long (give it a try with languages you know):

"Tâches des nouveaux arrivants, Suggestion : ajouter des liens"

And a longer tag could make tags being perceived as compacted on mobile. However, adding the two tags is a plus for experienced users reviewing newcomers tasks. With the two tags, they can review both all newcomers tasks (add links, add images...) but they can also narrow down their selection to a specific task.

With all this in mind, would recommend to go with the two tags: "Newcomers tasks, Suggested: add links".

From a technical perspective, is it possible to do the following?

For each entryIn filters
Capture d’écran_2020-11-18_11-45-11.png (93×574 px, 19 KB)
Capture d’écran_2020-11-18_11-46-57.png (381×831 px, 65 KB)

the goal is to allow mentors or patrollers to select all edits newcomers tasks, or only specific tasks in their RCs or Watchlist. But for each entry, we should only display the most specific tag and avoid something like "Newcomers tasks, Newcomers tasks, Suggested: add links" in lists of edits.

Thanks, @Trizek-WMF. Okay, with that advice we will use both tags.

Change 645297 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] [WIP] Add LinkRecommendation task type

https://gerrit.wikimedia.org/r/645297

Change 645297 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add LinkRecommendation task type

https://gerrit.wikimedia.org/r/645297

kostajh moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Not really possible to QA until we get the beta sites and testwiki updated.

Moving for @MMiller_WMF review.

To summarize

  • Newcomer task Suggested: add links tag can be applied to edits that are not related "Add links". This is how "Newcomer task" tag works: a user arrives to to an article via SE and do whatever edits that would get the tag Newcomer task.
  • based on the above, the value Newcomer task Suggested: add links tag would be to indicate that edits were made on an article that is in the "Add links" article pool - is it ok for now?
  • the task description implies that Newcomer task Suggested: add links tag would be applied only if, at least, some of the edits are done via Add links dialog boxes. Since it's not a case, should tagged process to be improved?
  • there are some details in a separate task T277518

The items marked with
(1)

The edit tag should apply even if the user makes other changes in the editor outside of the link targets, though this is not going to be possible in the first version of the feature. Users will have to either publish or >discard their link additions before using the visual editor on the article.

First, it's possible right now.
Second, even if the user doesn't make any Add links actions, the edits are tagged with Suggested: add links.

(2)

The edit tag should only apply to edits made through our "add links" interface, not other edits made by the user to the selected article. In the future, we may allow users to access this suggested edit task type through routes apart from the feed on the newcomer homepage. The tag should apply in those situations, too.

Does it contradict to the above?

The current behavior on testwiki

  • VE interface is disabled when performing "Add (suggested) link" task, but it's possible to switch to the source editor (without performing any Add link task) and do editing unrelated to Newcomer tasks. Those edits will be marked with the tags: Newcomer task Suggested: add links - filed as T277518

We're waiting for @Tgr's thoughts on T277518 before resolving here. It looks like all the issues @Etonkovidova listed are captured on that task. Is that correct @Etonkovidova?

We're waiting for @Tgr's thoughts on T277518 before resolving here. It looks like all the issues @Etonkovidova listed are captured on that task. Is that correct @Etonkovidova?

Right, thanks @MMiller_WMF and @Tgr.

Rileych claimed this task.