matching gifts values don't match between databases
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• MNoorWMF
	Oct 26 2020, 2:55 PM

Description

another matching gifts ticket :(

Our Trilogy rep, Briana, noticed that the employe_id and employer_name between our all_wikimedia list and the matching gifts database don't match.

For example, she showed us the example of "CSG International". The employer_id for this in the Matching Gifts db is 2415.

When we attempted to search for this in all_wiki, nothing popped up. However, a search of "CSG" gave us many results with the employer_name "CSG International Systems Inc" and an employer_id of 19956117.

Screen Shot 2020-10-20 at 11.59.44 AM.png (190×610 px, 22 KB)

Seems the values are mismatched entirely. I worry this will cause problems with our data integration when the program is live.

Details

	Subject	Repo	Branch	Lines +/-
	Fix incorrect id field choice on matching gift data	wikimedia/fundraising/tools	master	+1 -1

Customize query in gerrit

Event Timeline

• MNoorWMF created this task.Oct 26 2020, 2:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2020, 2:55 PM

My main questions around this are:

is this intentional? if this is the intended behavior, it will cause quite a bit of problems when we QA the templates as well as when the data gets reintegrated back into all_wikimedia with different values for each organization name and id.

where did the original values come from that are in all_wikimedia, and how did they become different from each other? my understanding was they came from the same db so i'm curious if there was something wrong with the original file somehow. although, we don't have any employee_id's that are only 4-digits long. 5-digits seems to be the minimum.

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Oct 26 2020, 7:59 PM

Oops, good catch @MNoorWMF. I think this will be a quick fix - we're probably pulling the 'id' column of the new table as opposed to the 'entity_id' column which links to the employer's ID in the contact table.

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Oct 27 2020, 9:06 PM

• DStrine added a project: Fundraising Sprint Vagranty McVagrantface.Oct 27 2020, 9:10 PM

• DStrine triaged this task as High priority.Oct 27 2020, 9:15 PM

• DStrine lowered the priority of this task from High to Medium.

Change 636768 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/tools@master] Fix incorrect id field choice on matching gift data

https://gerrit.wikimedia.org/r/636768

gerritbot added a project: Patch-For-Review.Oct 28 2020, 12:50 AM

Eileenmcnaughton claimed this task.Oct 28 2020, 12:50 AM

Eileenmcnaughton moved this task from Backlog to Review on the Fundraising Sprint Vagranty McVagrantface board.

Change 636768 merged by jenkins-bot:
[wikimedia/fundraising/tools@master] Fix incorrect id field choice on matching gift data

https://gerrit.wikimedia.org/r/636768

Maintenance_bot removed a project: Patch-For-Review.Oct 28 2020, 2:10 AM

Eileenmcnaughton moved this task from Review to Done on the Fundraising Sprint Vagranty McVagrantface board.Oct 28 2020, 2:12 AM

@MNoorWMF can you confirm this is closable?

I have Briana on this task right now, will check with her on Monday if that's an okay deadline to QA this?

perfect!

• DStrine added a project: Fundraising Sprint We all meet again.Nov 10 2020, 9:00 PM

Eileenmcnaughton moved this task from Backlog to Done on the Fundraising Sprint We all meet again board.Nov 11 2020, 12:11 AM

@MNoorWMF did you check?

@MNoorWMF any updates on this?

• DStrine moved this task from Current Sprint to Sprint +2 on the Fundraising-Backlog board.Nov 24 2020, 8:28 PM

Moska is out of office, but I'm pretty sure QA checks are almost complete except one last thing Briana needs Moska for. That's all I know for now, but Moska returns tomorrow so she may be able to chime in then. Thanks!

• DStrine moved this task from Sprint +2 to Q3 2021-2022 on the Fundraising-Backlog board.Jan 3 2021, 8:11 PM

• DStrine added a project: FR-matching-gifts.Aug 2 2021, 9:11 PM

• DStrine moved this task from Q3 2021-2022 to Sprint +2 on the Fundraising-Backlog board.Aug 2 2021, 9:14 PM

• DStrine moved this task from Sprint +2 to Sprint +1 on the Fundraising-Backlog board.

• DStrine moved this task from Sprint +1 to Sprint +3 on the Fundraising-Backlog board.Sep 13 2021, 3:57 PM

• DStrine moved this task from Sprint +3 to Q3 2021-2022 on the Fundraising-Backlog board.

XenoRyet moved this task from Q3 2021-2022 to Unscheduled on the Fundraising-Backlog board.Mar 13 2023, 5:47 PM

@Eileenmcnaughton: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Ejegg closed this task as Resolved.Dec 11 2023, 4:57 PM

Ejegg claimed this task.

	F32414742: Screen Shot 2020-10-20 at 11.59.44 AM.png
	Oct 26 2020, 2:55 PM

	F32414740: Screen Shot 2020-10-20 at 11.57.55 AM.png
	Oct 26 2020, 2:55 PM

matching gifts values don't match between databasesClosed, ResolvedPublicActions

Description

Details

Event Timeline

matching gifts values don't match between databases
Closed, ResolvedPublic
Actions