Page MenuHomePhabricator

Deprecate and remove wfMemcKey()
Closed, ResolvedPublic

Description

Callers should use the makeKey()/makeGlobalKey() method on the appropriate BagOStuff or WANObjectCache instance.

https://codesearch.wmcloud.org/deployed/?q=wfMemcKey&i=nope&files=&repos=

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/LifeWebmaster+3 -3
mediawiki/extensions/OnlineStatusBarmaster+4 -6
mediawiki/extensions/PhpTagsmaster+6 -6
mediawiki/extensions/HitCountersmaster+5 -4
mediawiki/extensions/HelpPagesmaster+6 -6
mediawiki/extensions/GroupWhitelistmaster+4 -3
mediawiki/extensions/GooglePlacesmaster+4 -4
mediawiki/extensions/GoogleAnalyticsMetricsmaster+1 -1
mediawiki/extensions/GoogleGeocodemaster+4 -4
mediawiki/extensions/Gitwebmaster+4 -3
mediawiki/extensions/ExternalDatamaster+3 -3
mediawiki/extensions/FlickrAPImaster+4 -4
mediawiki/extensions/BiblioPlusmaster+5 -5
mediawiki/extensions/SpecialNamespacesmaster+3 -3
mediawiki/extensions/SecureSessionsmaster+17 -18
mediawiki/extensions/PageFormsmaster+11 -9
mediawiki/extensions/TwnMainPagemaster+9 -11
mediawiki/coremaster+1 -22
mediawiki/extensions/Translatemaster+87 -67
mediawiki/extensions/Petitionmaster+2 -2
mediawiki/extensions/FeaturedFeedsmaster+25 -27
mediawiki/extensions/ExtensionDistributormaster+5 -5
mediawiki/extensions/TranslationNotificationsmaster+2 -2
mediawiki/extensions/UploadWizardmaster+14 -7
Show related patches Customize query in gerrit

Event Timeline

Change 636481 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/UploadWizard@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636481

Change 636482 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/TranslationNotifications@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636482

Change 636483 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/ExtensionDistributor@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636483

Change 636485 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/FeaturedFeeds@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636485

Change 636481 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636481

Change 636482 merged by jenkins-bot:
[mediawiki/extensions/TranslationNotifications@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636482

Change 636483 merged by jenkins-bot:
[mediawiki/extensions/ExtensionDistributor@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636483

Krinkle removed aaron as the assignee of this task.Nov 2 2020, 7:39 PM
Krinkle updated the task description. (Show Details)
Krinkle added a subscriber: Krinkle.

per our Monday triage and the Codesearch link, it seems another extension is still using this, namely Translate, and "Petition".

Change 636485 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636485

Change 638166 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/extensions/Petition@master] Avoid use of deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/638166

Change 638166 merged by jenkins-bot:
[mediawiki/extensions/Petition@master] Avoid use of deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/638166

Change 636756 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] Remove deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/636756

Change 640840 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/Translate@master] Remove deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/640840

Change 640840 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/640840

Change 636756 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/636756

Krinkle moved this task from Untriaged to libs/objectcache on the MediaWiki-Cache board.
Nikerabbit added a subscriber: Nikerabbit.

I'm requesting a revert of the removal of wfMemckey for time being, because it blocks deployments on translatewiki.net as it's still being used by two extensions we use (TwnMainPage and PageForms).

Quoting Stable interface policy:

Removal
Code MUST emit hard deprecation notices for at least one major MediaWiki version before being removed. It is RECOMMENDED to emit hard deprecation notices for at least two major MediaWiki versions. EXCEPTIONS to this are listed in the section "Changes without deprecation" below.

I am not mistaken, wfMemckey was never hard-deprecated.

Change 643546 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/TwnMainPage@master] Avoid use of deprecated wfMemcKey()

https://gerrit.wikimedia.org/r/643546

Change 643547 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/PageForms@master] Avoid use of deprecated wfMemcKey()

https://gerrit.wikimedia.org/r/643547

Change 643511 had a related patch set uploaded (by Krinkle; owner: Nikerabbit):
[mediawiki/extensions/PageForms@master] Avoid deprecated wfMemcKey

https://gerrit.wikimedia.org/r/643511

Change 643509 had a related patch set uploaded (by Krinkle; owner: Nikerabbit):
[mediawiki/extensions/TwnMainPage@master] Avoid deprecated cache functions

https://gerrit.wikimedia.org/r/643509

Change 643509 merged by jenkins-bot:
[mediawiki/extensions/TwnMainPage@master] Avoid deprecated cache functions

https://gerrit.wikimedia.org/r/643509

Change 643547 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Avoid use of deprecated wfMemcKey()

https://gerrit.wikimedia.org/r/643547

Change 646694 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/PhpTags@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646694

Change 646701 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SecureSessions@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646701

Change 646702 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SpecialNamespaces@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646702

Change 646703 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/BiblioPlus@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646703

Change 646707 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ExternalData@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646707

Change 646709 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/FlickrAPI@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646709

Change 646710 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Gitweb@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646710

Change 646712 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GoogleAnalyticsMetrics@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646712

Change 646713 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GoogleGeocode@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646713

Change 646715 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GooglePlaces@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646715

Change 646716 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GroupWhitelist@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646716

Change 646726 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/HelpPages@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646726

Change 646727 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/HitCounters@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646727

Change 646728 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/LifeWeb@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646728

Change 646729 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/OnlineStatusBar@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646729

Change 646701 merged by jenkins-bot:
[mediawiki/extensions/SecureSessions@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646701

Change 646702 merged by jenkins-bot:
[mediawiki/extensions/SpecialNamespaces@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646702

Change 646703 merged by jenkins-bot:
[mediawiki/extensions/BiblioPlus@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646703

Change 646709 merged by jenkins-bot:
[mediawiki/extensions/FlickrAPI@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646709

Change 646707 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646707

Change 646710 merged by jenkins-bot:
[mediawiki/extensions/Gitweb@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646710

Change 646713 merged by jenkins-bot:
[mediawiki/extensions/GoogleGeocode@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646713

Change 646712 merged by jenkins-bot:
[mediawiki/extensions/GoogleAnalyticsMetrics@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646712

Change 646715 merged by jenkins-bot:
[mediawiki/extensions/GooglePlaces@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646715

Change 646716 merged by jenkins-bot:
[mediawiki/extensions/GroupWhitelist@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646716

Change 646726 merged by jenkins-bot:
[mediawiki/extensions/HelpPages@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646726

Change 646727 merged by jenkins-bot:
[mediawiki/extensions/HitCounters@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646727

Change 646694 merged by jenkins-bot:
[mediawiki/extensions/PhpTags@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646694

Change 646729 merged by jenkins-bot:
[mediawiki/extensions/OnlineStatusBar@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646729

Change 646728 merged by jenkins-bot:
[mediawiki/extensions/LifeWeb@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646728