Page MenuHomePhabricator
Create Task
Maniphest T266502

Deprecate and remove wfMemcKey()
Closed, ResolvedPublic
Actions

Description

Callers should use the makeKey()/makeGlobalKey() method on the appropriate BagOStuff or WANObjectCache instance.

https://codesearch.wmcloud.org/deployed/?q=wfMemcKey&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Replaced removed wfMemcKeymediawiki/extensions/LifeWebmaster+3 -3
Replaced removed wfMemcKeymediawiki/extensions/OnlineStatusBarmaster+4 -6
Replaced removed wfMemcKeymediawiki/extensions/PhpTagsmaster+6 -6
Replaced removed wfMemcKeymediawiki/extensions/HitCountersmaster+5 -4
Replaced removed wfMemcKeymediawiki/extensions/HelpPagesmaster+6 -6
Replaced removed wfMemcKeymediawiki/extensions/GroupWhitelistmaster+4 -3
Replaced removed wfMemcKeymediawiki/extensions/GooglePlacesmaster+4 -4
Replaced removed wfMemcKeymediawiki/extensions/GoogleAnalyticsMetricsmaster+1 -1
Replaced removed wfMemcKeymediawiki/extensions/GoogleGeocodemaster+4 -4
Replaced removed wfMemcKeymediawiki/extensions/Gitwebmaster+4 -3
Replaced removed wfMemcKeymediawiki/extensions/ExternalDatamaster+3 -3
Replaced removed wfMemcKeymediawiki/extensions/FlickrAPImaster+4 -4
Replaced removed wfMemcKeymediawiki/extensions/BiblioPlusmaster+5 -5
Replaced removed wfMemcKeymediawiki/extensions/SpecialNamespacesmaster+3 -3
Replaced removed wfMemcKeymediawiki/extensions/SecureSessionsmaster+17 -18
Avoid use of deprecated wfMemcKey()mediawiki/extensions/PageFormsmaster+11 -9
Avoid deprecated cache functionsmediawiki/extensions/TwnMainPagemaster+9 -11
Remove deprecated wfMemcKey() functionmediawiki/coremaster+1 -22
Remove deprecated wfMemcKey() functionmediawiki/extensions/Translatemaster+87 -67
Avoid use of deprecated wfMemcKey() functionmediawiki/extensions/Petitionmaster+2 -2
Avoid use of deprecated wfMemcKey() methodmediawiki/extensions/FeaturedFeedsmaster+25 -27
Avoid use of deprecated wfMemcKey() methodmediawiki/extensions/ExtensionDistributormaster+5 -5
Avoid use of deprecated wfMemcKey() methodmediawiki/extensions/TranslationNotificationsmaster+2 -2
Avoid use of deprecated wfMemcKey() methodmediawiki/extensions/UploadWizardmaster+14 -7
Show related patches Customize query in gerrit

Related Objects

Event Timeline

aaron created this task.Oct 26 2020, 7:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2020, 7:34 PM
gerritbot added a comment.Oct 26 2020, 7:34 PM

Change 636481 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/UploadWizard@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636481

gerritbot added a project: Patch-For-Review.Oct 26 2020, 7:34 PM

Change 636482 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/TranslationNotifications@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636482

gerritbot added a comment.Oct 26 2020, 7:38 PM

Change 636483 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/ExtensionDistributor@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636483

gerritbot added a comment.Oct 26 2020, 7:40 PM

Change 636485 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/FeaturedFeeds@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636485

gerritbot added a comment.Oct 26 2020, 8:11 PM

Change 636481 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636481

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 26 2020, 9:00 PM
gerritbot added a comment.Oct 26 2020, 9:24 PM

Change 636482 merged by jenkins-bot:
[mediawiki/extensions/TranslationNotifications@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636482

gerritbot added a comment.Oct 26 2020, 9:24 PM

Change 636483 merged by jenkins-bot:
[mediawiki/extensions/ExtensionDistributor@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636483

• Gilles assigned this task to aaron.Nov 2 2020, 7:39 PM
Krinkle removed aaron as the assignee of this task.Nov 2 2020, 7:39 PM
Krinkle updated the task description. (Show Details)
• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Nov 2 2020, 7:39 PM
Krinkle assigned this task to aaron.Nov 6 2020, 9:25 PM
Krinkle added a project: Technical-Debt (Deprecation process).Nov 6 2020, 9:27 PM
Krinkle moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
Krinkle subscribed.

per our Monday triage and the Codesearch link, it seems another extension is still using this, namely Translate, and "Petition".

gerritbot added a comment.Nov 6 2020, 9:31 PM

Change 636485 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@master] Avoid use of deprecated wfMemcKey() method

https://gerrit.wikimedia.org/r/636485

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.18; 2020-11-17); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 6 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 6 2020, 10:10 PM
gerritbot added a comment.Nov 6 2020, 10:43 PM

Change 638166 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/extensions/Petition@master] Avoid use of deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/638166

gerritbot added a project: Patch-For-Review.Nov 6 2020, 10:43 PM
Krinkle mentioned this in T267450: Stop branching the Petition repo for production (and thus showing up in CodeSearch).Nov 6 2020, 10:47 PM
gerritbot added a comment.Nov 6 2020, 10:48 PM

Change 638166 merged by jenkins-bot:
[mediawiki/extensions/Petition@master] Avoid use of deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/638166

gerritbot added a comment.Nov 6 2020, 10:48 PM

Change 636756 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] Remove deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/636756

gerritbot added a comment.Nov 12 2020, 6:43 PM

Change 640840 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/Translate@master] Remove deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/640840

gerritbot added a comment.Nov 16 2020, 2:48 PM

Change 640840 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/640840

gerritbot added a comment.Nov 24 2020, 4:53 PM

Change 636756 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated wfMemcKey() function

https://gerrit.wikimedia.org/r/636756

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.20; 2020-12-01); removed MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Nov 24 2020, 5:00 PM
Krinkle closed this task as Resolved.Nov 24 2020, 6:32 PM
Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.
Nikerabbit reopened this task as Open.Nov 25 2020, 3:01 PM
Nikerabbit subscribed.

I'm requesting a revert of the removal of wfMemckey for time being, because it blocks deployments on translatewiki.net as it's still being used by two extensions we use (TwnMainPage and PageForms).

Quoting Stable interface policy:

Removal
Code MUST emit hard deprecation notices for at least one major MediaWiki version before being removed. It is RECOMMENDED to emit hard deprecation notices for at least two major MediaWiki versions. EXCEPTIONS to this are listed in the section "Changes without deprecation" below.

I am not mistaken, wfMemckey was never hard-deprecated.

gerritbot added a comment.Nov 25 2020, 8:23 PM

Change 643546 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/TwnMainPage@master] Avoid use of deprecated wfMemcKey()

https://gerrit.wikimedia.org/r/643546

gerritbot added a comment.Nov 25 2020, 8:28 PM

Change 643547 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/PageForms@master] Avoid use of deprecated wfMemcKey()

https://gerrit.wikimedia.org/r/643547

gerritbot added a comment.Nov 26 2020, 3:44 AM

Change 643511 had a related patch set uploaded (by Krinkle; owner: Nikerabbit):
[mediawiki/extensions/PageForms@master] Avoid deprecated wfMemcKey

https://gerrit.wikimedia.org/r/643511

gerritbot added a comment.Nov 26 2020, 3:52 AM

Change 643509 had a related patch set uploaded (by Krinkle; owner: Nikerabbit):
[mediawiki/extensions/TwnMainPage@master] Avoid deprecated cache functions

https://gerrit.wikimedia.org/r/643509

gerritbot added a comment.Nov 26 2020, 3:57 AM

Change 643509 merged by jenkins-bot:
[mediawiki/extensions/TwnMainPage@master] Avoid deprecated cache functions

https://gerrit.wikimedia.org/r/643509

gerritbot added a comment.Dec 2 2020, 12:41 PM

Change 643547 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Avoid use of deprecated wfMemcKey()

https://gerrit.wikimedia.org/r/643547

Nikerabbit mentioned this in rEPFM71818b9769ef: Avoid use of deprecated wfMemcKey().Dec 2 2020, 12:43 PM
gerritbot added a comment.Dec 7 2020, 2:49 PM

Change 646694 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/PhpTags@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646694

gerritbot added a comment.Dec 7 2020, 2:53 PM

Change 646701 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SecureSessions@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646701

gerritbot added a comment.Dec 7 2020, 2:54 PM

Change 646702 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SpecialNamespaces@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646702

gerritbot added a comment.Dec 7 2020, 2:56 PM

Change 646703 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/BiblioPlus@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646703

gerritbot added a comment.Dec 7 2020, 2:57 PM

Change 646707 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ExternalData@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646707

gerritbot added a comment.Dec 7 2020, 2:58 PM

Change 646709 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/FlickrAPI@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646709

gerritbot added a comment.Dec 7 2020, 2:59 PM

Change 646710 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Gitweb@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646710

gerritbot added a comment.Dec 7 2020, 3:01 PM

Change 646712 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GoogleAnalyticsMetrics@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646712

gerritbot added a comment.Dec 7 2020, 3:01 PM

Change 646713 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GoogleGeocode@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646713

gerritbot added a comment.Dec 7 2020, 3:02 PM

Change 646715 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GooglePlaces@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646715

gerritbot added a comment.Dec 7 2020, 3:03 PM

Change 646716 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GroupWhitelist@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646716

gerritbot added a comment.Dec 7 2020, 3:05 PM

Change 646726 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/HelpPages@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646726

gerritbot added a comment.Dec 7 2020, 3:06 PM

Change 646727 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/HitCounters@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646727

gerritbot added a comment.Dec 7 2020, 3:07 PM

Change 646728 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/LifeWeb@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646728

gerritbot added a comment.Dec 7 2020, 3:08 PM

Change 646729 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/OnlineStatusBar@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646729

gerritbot added a comment.Dec 7 2020, 3:45 PM

Change 646701 merged by jenkins-bot:
[mediawiki/extensions/SecureSessions@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646701

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646702 merged by jenkins-bot:
[mediawiki/extensions/SpecialNamespaces@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646702

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646703 merged by jenkins-bot:
[mediawiki/extensions/BiblioPlus@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646703

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646709 merged by jenkins-bot:
[mediawiki/extensions/FlickrAPI@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646709

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646707 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646707

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646710 merged by jenkins-bot:
[mediawiki/extensions/Gitweb@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646710

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646713 merged by jenkins-bot:
[mediawiki/extensions/GoogleGeocode@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646713

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646712 merged by jenkins-bot:
[mediawiki/extensions/GoogleAnalyticsMetrics@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646712

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646715 merged by jenkins-bot:
[mediawiki/extensions/GooglePlaces@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646715

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646716 merged by jenkins-bot:
[mediawiki/extensions/GroupWhitelist@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646716

gerritbot added a comment.Dec 7 2020, 3:46 PM

Change 646726 merged by jenkins-bot:
[mediawiki/extensions/HelpPages@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646726

gerritbot added a comment.Dec 7 2020, 4:01 PM

Change 646727 merged by jenkins-bot:
[mediawiki/extensions/HitCounters@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646727

gerritbot added a comment.Dec 7 2020, 4:05 PM

Change 646694 merged by jenkins-bot:
[mediawiki/extensions/PhpTags@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646694

gerritbot added a comment.Dec 7 2020, 4:09 PM

Change 646729 merged by jenkins-bot:
[mediawiki/extensions/OnlineStatusBar@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646729

aaron closed this task as Resolved.Dec 7 2020, 7:01 PM
gerritbot added a comment.Dec 9 2020, 10:34 AM

Change 646728 merged by jenkins-bot:
[mediawiki/extensions/LifeWeb@master] Replaced removed wfMemcKey

https://gerrit.wikimedia.org/r/646728

Kghbln mentioned this in T277494: Too few arguments to function ObjectCache::getInstance(), 0 passed in "HitCounters.body.php" on line 39 and exactly 1 expected.Mar 15 2021, 6:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL