Page MenuHomePhabricator

Include canonical special page name for JS error reports
Closed, ResolvedPublic

Description

With no source maps, there is no great way to identfy errors coming from a specific component. With components only used on some special page the page name would be a decent proxy, but URLs are not really useful for identifying special pages due to i18n. It would be nice if the canonical special page name was included with the error as an extra field.

Event Timeline

Change 634295 had a related patch set uploaded (by Jason Linehan; owner: Jason Linehan):
[mediawiki/extensions/WikimediaEvents@master] clientError: Adds new fields and updates behavior.

https://gerrit.wikimedia.org/r/634295

Change 693936 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaEvents@master] Include canonical special page name for JS error reports without schema change

https://gerrit.wikimedia.org/r/693936

Change 693936 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Include canonical special page name for JS error reports without schema change

https://gerrit.wikimedia.org/r/693936

Jdlrobson claimed this task.
Jdlrobson subscribed.

I will verify this is working correctly on Thursday 24th and report back.

Change 700241 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/WikimediaEvents@master] clientError: Use dedicated field for canonical special page name

https://gerrit.wikimedia.org/r/700241

Change 700243 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[schemas/event/primary@master] mediawiki/client/error: Add canonical special page name

https://gerrit.wikimedia.org/r/700243

This appears to be working. In German Wikipedia it's Spezial:Anmelden but in error logs this error it shows up as Special:GlobalPreferences:

Screen Shot 2021-06-25 at 8.48.25 AM.png (100×1 px, 18 KB)

(Also I checked and the file URL for that issue contains lang=de so they haven't switched language)

Change 634295 abandoned by Jdlrobson:

[mediawiki/extensions/WikimediaEvents@master] clientError: Adds new fields and updates behavior.

Reason:

No longer being worked on

https://gerrit.wikimedia.org/r/634295

Change 700243 abandoned by Gergő Tisza:

[schemas/event/primary@master] mediawiki/client/error: Add canonical special page name

Reason:

based on discussions in various places, I think there's consensus that tags are preferred over new fields.

https://gerrit.wikimedia.org/r/700243

Change 700241 abandoned by Gergő Tisza:

[mediawiki/extensions/WikimediaEvents@master] clientError: Use dedicated field for canonical special page name

Reason:

This was done in If8d5732cd2e973df7096b88bdbc824e69bb58961

https://gerrit.wikimedia.org/r/700241