Page MenuHomePhabricator

TypeError: baseHref is undefined on search
Closed, ResolvedPublic


This is showing up in production logs in on Vector. Possibly relates to T217726 ?

at getFormData URL1:17:501
at specialRenderFunction URL1:19:915
at special/< URL1:4:843


Event Timeline

baseHref is set by $form.attr( 'action' ), not sure why it can fail on, because it looks core function used here

Maybe this is not the search form on every page view? It may be a search form on a special page not set up correctly. It is possible to get a page name from there the error is coming?

Change 670558 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Defensively program for action attribute

I can replicate this by running the code $('#searchform').removeAttr('action') and focusing the search area. We run gadgets so highly likely a gadget is doing that. Some defensive programming is low cost and will avoid this error.

Change 670558 merged by jenkins-bot:
[mediawiki/core@master] Defensively program for action attribute

Jdlrobson claimed this task.

Will reopen next thursday if persisting