Page MenuHomePhabricator

Set ENV SERVERGROUP for jobrunner MW web requests
Closed, ResolvedPublic

Description

SERVERGROUP is set to one of appserver, api_appserver, or parsoid currently. For jobrunner, it is currently unset.

It would help with Logstash monitioring if it identifies the jobrunner group as such as well. These are currently attributed to other among mwmaint* and snapshot* hosts.

Related:

  • Introduce SERVERGROUP: T235899
  • Use SERVERGROUP in Logstash: T255627
  • Set SERVERGROUP different on mwdebug servers: T262202

Event Timeline

Job execution currently uses the /rpc/RunSingleJob endpoint in production which iirc has its own VirtualHost, that might explain the absence. It's possible that after T246371, when using the core end point directly, that this would naturally get the ENV var set correctly. If the provisioning works that way currently, then this can depend on T246371 and might not need any action depending on the timeline for that transition.

lmata added a subscriber: lmata.

Please let us know if there is anything we can assist with... moving to radar meanwhile.

AMooney triaged this task as Medium priority.Nov 10 2020, 9:22 PM
AMooney added a subscriber: AMooney.

We think after task T246371 is complete, this will be resolved. Requesting to decline.

Marking as sub task accordingly. We can confirm afterwards or re-prioritize then.

@AMooney I don't think that task will be fast to complete, also because we should really dedicate our energies to transitioning MediaWiki to Kubernetes, and freeze all the rest of the work that's unrelated for now. Adding the env variable to the jobrunners is matter of one simple patch, and I'll tak that on.

Change 640923 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/puppet@production] jobrunner: add SERVERGROUP environment variable

https://gerrit.wikimedia.org/r/640923

Change 640923 merged by Giuseppe Lavagetto:
[operations/puppet@production] jobrunner: add SERVERGROUP environment variable

https://gerrit.wikimedia.org/r/640923