Mark Clinic Duty Stats as Historical
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Physikerwelt
	Oct 27 2020, 9:12 AM

Description

As a volunteer contributor, code review from WMF is important to ensure that the code is aligned with the WMF guidelines and principals. Otherwise, the overall code congruence of the MediaWiki project is at risk.
According to my (@Physikerwelt) understanding, the idea was to create a external code review board maintained by the Clinic Duty Team. I wanted to check how this workboard eveloved and found

Screenshot_2020-10-27 Clinic Duty Stats - cpt.png (400×500 px, 13 KB)

on
https://wikifarm.wmflabs.org/cpt/index.php/Clinic_Duty_Stats
. I am having difficulties to understand what that means. It seems that the frequency of external code reviews decreased even though the requests went up. Is that correct?

Related Objects

Mentioned In: T242360: Update CPT Clinic Duty page with current processes

Event Timeline

Physikerwelt created this task.Oct 27 2020, 9:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2020, 9:12 AM

WDoranWMF edited projects, added Platform Engineering; removed Platform Team Workboards (Clinic Duty Team).Oct 27 2020, 11:42 AM

Hi @Physikerwelt that smw instance was used to pull public data from phab over and add structure to attempt to create stats about progress. Linking up a tasks progression through a board requires gathering the data through a complex set of queries that are tied to the board itself.

We're not currently using the smw instance to track stats because the manual effort was high due to the complex phab API. It also doesn't capture any gerrit data so misses reviews done there. It also is only public data so misses reviews done on security tasks which are commonly UbN.

That set of graphs, I believe, specifically tracks the *old* board not the external code review board. @CCicalese_WMF is that correct?

What the code review graphs on that page tracked was the columns on the Clinic Duty board and the snapshot of the number of tasks in each on a sprint by sprint basis. So overtime the number of external code reviews dropped or flattened. It's not great for external consumption as it requires extra info for interpretation.

Having public stats would be great though and would make understanding the capacity and focus more transparent. @AMooney let's discuss at our next meeting if we can publish regular stats/progress.

That set of graphs, I believe, specifically tracks the *old* board not the external code review board. @CCicalese_WMF is that correct?

That graph does track both the old workboard columns as well as the new ones. It does miss code reviews that happen completely in gerrit without an associated Phab task, although fewer of those seem to be coming to clinic duty. It could possibly be that some of the code reviews in the earlier spikes were internal code reviews for our team rather than external code reviews, and those are now tracked separately.

• AMooney triaged this task as Low priority.Nov 3 2020, 3:09 PM

• AMooney edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.

• AMooney moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.

What exactly is left to do in this task? Moving the task comments to a wiki page so they could be found?

@WDoranWMF: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Looks like https://wikifarm.wmflabs.org/cpt/index.php/Clinic_Duty_Stats is dead - no updates for years. Maybe it's time to sunset the entire site?

The site currently exists purely for historical purposes as well as for a technical example of potential MediaWiki/phabricator integration. I am declining the task since the Clinic Duty Team is no longer active, so the intent of the task is now moot. But, the site incurs minimal cost and will remain as an example.

In T266534#8799650, @CCicalese_WMF wrote:

The site currently exists purely for historical purposes as well as for a technical example of potential MediaWiki/phabricator integration.

I don't think that is helpful as I am unable to find the code for this "potential MediaWiki/phabricator integration". Most links in the footer are 404s. I doubt realistic "historical purpose" (interest). I propose to take things down when things do not clearly tell their viewer that they are outdated and rotting, like many WM things.

I am declining the task since the Clinic Duty Team is no longer active, so the intent of the task is now moot.

In that case https://phabricator.wikimedia.org/project/profile/4149/ should get archived and https://www.mediawiki.org/wiki/Core_Platform_Team/PET_Work_Processes/Clinic_Duty should be updated or marked as {{historical}} (and probably many other CPT/PET pages too).

But, the site incurs minimal cost and will remain as an example.

Outdated information not identifiable as outdated information is not "minimal cost" at all. It's huge costs when trying to find some relevant information instead.

Aklapper renamed this task from Explain and communicate Clinic Duty Stats to Undeploy Clinic Duty Stats.Apr 23 2023, 8:55 AM

Aklapper removed a subscriber: • AMooney.

In T266534#8799738, @Aklapper wrote:

In T266534#8799650, @CCicalese_WMF wrote:

The site currently exists purely for historical purposes as well as for a technical example of potential MediaWiki/phabricator integration.

I don't think that is helpful as I am unable to find the code for this "potential MediaWiki/phabricator integration".

I'm not quite sure how to respond to this. If you were to look at the page source, you would see that the graphs are generated from Lua code in Module:Reports. If you were to dig a bit deeper, you would see that the site runs extension PhabTaskGraph which includes a maintenance script that scrapes information from Phabricator and creates pages in the wiki corresponding to Phabricator tasks. Although the site has received minimal new content for a while, since the Phab tags it is watching are no longer active, the code itself in the site is quite useful - for historical purposes, as I stated. If we were to want to do something similar in the future, the code on this site would be extremely useful, whether you find it so or not.

Most links in the footer are 404s.

Not 404s, but pages that were never populated on that wiki. That is not relevant to the usefulness of other content on the site.

I doubt realistic "historical purpose" (interest).

I disagree.

I propose to take things down when things do not clearly tell their viewer that they are outdated and rotting, like many WM things.

I have added a sitenotice to the top of the wiki to indicate that the site is not actively maintained.

I am declining the task since the Clinic Duty Team is no longer active, so the intent of the task is now moot.

In that case https://phabricator.wikimedia.org/project/profile/4149/ should get archived

Done.

and https://www.mediawiki.org/wiki/Core_Platform_Team/PET_Work_Processes/Clinic_Duty should be updated or marked as {{historical}}

I marked it as historical.

(and probably many other CPT/PET pages too).

Out of scope for this task.

Aklapper mentioned this in T242360: Update CPT Clinic Duty page with current processes.Apr 24 2023, 3:16 PM

Thanks _a lot_ for archiving, marking as historical, adding a sitenotice. Indeed, I should have investigated the source page... sorry.

	F32416040: Screenshot_2020-10-27 Clinic Duty Stats - cpt.png
	Oct 27 2020, 9:12 AM

Mark Clinic Duty Stats as HistoricalClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Mark Clinic Duty Stats as Historical
Closed, ResolvedPublic
Actions