Page MenuHomePhabricator
Create Task
Maniphest T266583

MediaWiki 1.35 should be compatible with PHP 8 per PHP support policy
Closed, ResolvedPublic
Actions

Description

The support policy for PHP states:

New major releases of MediaWiki must support at least one PHP version for each of the following criteria:
A PHP version that will be supported by the upstream PHP Group for the full duration of that MediaWiki major release cycle (from our planned release date until our planned end-of-life date).

Support for MW 1.35 is expected to last until September 2023. However, security support for PHP 7.4 ends 28 Nov 2022. Thus, if we want to adhere to the policy, patches for PHP8 support should be backported to 1.35. Or we can make an exception to the policy ¯\_(ツ)_/¯

Related Objects
Search...

Event Timeline

Daimona created this task.Oct 27 2020, 5:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2020, 5:33 PM
Jdforrester-WMF subscribed.Oct 27 2020, 5:42 PM

Policy is about MW support at release time. PHP 8 wasn't out by the time MW 1.35 was cut; it still isn't.

Daimona added a comment.Oct 27 2020, 5:55 PM
In T266583#6582320, @Jdforrester-WMF wrote:

Policy is about MW support at release time. PHP 8 wasn't out by the time MW 1.35 was cut; it still isn't.

Good point. However, that leaves the problem of not offering support for a supported PHP version for one year. Again, we can just live with that. Or perhaps consider backporting PHP8-related changes to a minor release of 1.35.

Jdforrester-WMF added a comment.Oct 27 2020, 6:02 PM
In T266583#6582382, @Daimona wrote:
In T266583#6582320, @Jdforrester-WMF wrote:

Policy is about MW support at release time. PHP 8 wasn't out by the time MW 1.35 was cut; it still isn't.

Good point. However, that leaves the problem of not offering support for a supported PHP version for one year. Again, we can just live with that. Or perhaps consider backporting PHP8-related changes to a minor release of 1.35.

Given how large the breaking changes in PHP 8 are, I imagine the backports would swiftly become non-trivial. That has advantages (easier security backports) to go with the large amount of extra work, but…

MacFan4000 subscribed.Nov 29 2020, 6:52 PM
Reedy moved this task from Blocker to Meta on the MW-1.35-release board.Dec 2 2020, 1:32 AM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.0 support board.Dec 8 2020, 2:59 AM
Reedy mentioned this in T269710: MW 1.35 Library Bumps for PHP 8.0.Dec 8 2020, 9:35 PM
Reedy added a subtask: T269710: MW 1.35 Library Bumps for PHP 8.0.
Reedy mentioned this in T269711: Document current PHP 8.0 support in MW 1.35 for 1.35.1.Dec 8 2020, 9:38 PM
Reedy mentioned this in T269714: Add PHP 8.0 non voting jobs to 1.35.Dec 8 2020, 10:20 PM
alex-mashin subscribed.Dec 30 2020, 5:48 AM
Jdforrester-WMF closed subtask T269710: MW 1.35 Library Bumps for PHP 8.0 as Resolved.Jan 18 2021, 11:51 PM
Jdforrester-WMF added a comment.Jan 19 2021, 12:05 AM

We're getting pretty close to being able to enable PHP 8.0 on CI for REL1_35 of MediaWiki itself; some outstanding ones I spotted (not a complete list):

Reedy subscribed.Jan 19 2021, 12:12 AM

We're gonna have to backport some of the lovely monolog support too (at some point)

Umherirrender mentioned this in T271575: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0.Feb 7 2021, 12:33 AM
Reedy added a subtask: T274966: Make MW 1.35 tests pass on PHP 8.0.Jan 29 2022, 5:06 PM
Reedy triaged this task as Low priority.Sep 30 2022, 2:22 AM
Afernawiki subscribed.Nov 14 2022, 2:17 AM

I have tested MW 1.35.7 with PHP 8.0.23. LDAP authentication for domain authentication works with PH 8.0.23.
I appreciate it if someone Can confirm the PHP 8.0.23 support for MW 1.35.7?
Thanks

Aklapper added a comment.Nov 14 2022, 9:18 AM

@Afernawiki: Welcome. There is nothing to confirm in this ticket. Please also see T248925. Feel free to bring this up at https://www.mediawiki.org/wiki/Project:Support_desk instead - thanks.

Reedy added a comment.Dec 16 2022, 5:58 PM

How much more effort should we put into this?

Reedy closed this task as Resolved.Jan 8 2023, 7:11 PM
Reedy closed subtask T274966: Make MW 1.35 tests pass on PHP 8.0 as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL