Page MenuHomePhabricator
Create Task
Maniphest T266585

Remove SpecialInvestigateLog, InvestigateLogPager and InvestigateLogPagerFactory
Closed, ResolvedPublic
Actions

Description

Following T266238: Show logs for Special:Investigate investigations on Special:CheckUserLog, the classes for building Special:Investigate should be removed, and any links pointing to Special:Investigate should instead point to Special:CheckUser.

Acceptance criteria from the parent task:

  • Link to the Special:Investigate form from the top of Special:CheckuserLog
  • Change the log button on Special:Investigate to link to Special:CheckuserLog
  • Remove SpecialInvestigateLog, InvestigateLogPager and InvestigateLogPagerFactory

Some additional acceptance criteria:

  • The "Check" tool link in the IPs & User agents tab links to Special:CheckUserLog
  • All messages for the removed classes are removed
  • Comments and documentation no longer refer to InvestigateLog

Details

SubjectRepoBranchLines +/-
Remove Special:InvestigateLog and associated classesmediawiki/extensions/CheckUsermaster+48 -307
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tchanders created this task.Oct 27 2020, 5:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2020, 5:43 PM
• Tchanders claimed this task.Oct 27 2020, 5:44 PM
• Tchanders added a parent task: T259791: Merge Special:InvestigateLog with Special:CheckUserLog.
• Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
• Tchanders mentioned this in T259791: Merge Special:InvestigateLog with Special:CheckUserLog.Oct 27 2020, 5:47 PM
• Tchanders updated the task description. (Show Details)Oct 29 2020, 2:59 PM
gerritbot added a comment.Oct 29 2020, 3:14 PM

Change 637512 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Remove Special:InvestigateLog and associated classes

https://gerrit.wikimedia.org/r/637512

gerritbot added a project: Patch-For-Review.Oct 29 2020, 3:14 PM
• Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Oct 29 2020, 3:14 PM
gerritbot added a comment.Nov 2 2020, 5:26 PM

Change 637512 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Remove Special:InvestigateLog and associated classes

https://gerrit.wikimedia.org/r/637512

• Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Nov 2 2020, 5:27 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 2 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 2 2020, 6:10 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.EditedNov 4 2020, 9:45 AM
dom_walden subscribed.
  • Link to the Special:Investigate form from the top of Special:CheckuserLog

Yes. ("Switch to Investigate main form" in the screenshot below.)

Also, if you filter the log to a specific target (i.e. Special:CheckUserLog/<user, ip or range>), we include a link to Special:Investigate?targets=<user, ip or range>. ("Investigate this user" in the screenshot below.)

checkuserlog_subtitles.png (177×650 px, 17 KB)

If you have checkuser-log rights but not checkuser rights, these links do not show.

If $wgCheckUserEnableSpecialInvestigate = false the Special:Investigate links still show, but will obviously take you to No such special page. As $wgCheckUserEnableSpecialInvestigate is true on production, perhaps this does not matter.

  • Change the log button on Special:Investigate to link to Special:CheckuserLog

Yes, both on the first page and during an investigation.

  • Remove SpecialInvestigateLog, InvestigateLogPager and InvestigateLogPagerFactory

Yes.

  • The "Check" tool link in the IPs & User agents tab links to Special:CheckUserLog

Yes.

When you click the "Check" tool, I notice that an EventLogging event is logged of the form:

{"event":{"action":"tool","tool":"Special:InvestigateLog"} ...

which is the same as it was before. I am guessing we want to keep this the same so we can continue to make comparisons.

  • All messages for the removed classes are removed

Yes, as far as I can tell.

The removed messages do not appear to be used anywhere else.

  • Comments and documentation no longer refer to InvestigateLog

I cannot find any references to InvestigateLog in code comments or wiki documentation (incl. https://www.mediawiki.org/wiki/Extension:CheckUser#Special:Investigate_usage, https://meta.wikimedia.org/wiki/Help:Special_Investigate).

Test environment: local vagrant MediaWiki 1.36.0-alpha (6e6fb0e) CheckUser 2.5 (5e69b2b).

Niharika closed this task as Resolved.Nov 4 2020, 4:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits