Page MenuHomePhabricator

Payment Method will not update on contribution record
Open, MediumPublic


On the contribution record dated Oct 27th for CID 72, I tried to update the payment method from cash to EFT. It seems to be updated on my end, but then does not show up when I do a contribution search with criteria:
-payment method: EFT
-date received: Oct 27th

It also shows that payment method is still cash on Leanne's civi.

Thank you for your help!

Event Timeline

Ahh, so that's the Anonymous contact record. I see two contributions on the 27th for that contact, one of which has a single EFT payment associated and the other (larger) one seems to have a bunch of alternating positive and negative Cash and EFT payments.

Under the hood, it looks like when you click edit on a payment to change the payment method, it records a negative payment against the original method, then a positive payment against the new payment method.

I'd guess that saving any edits to that contact take a long time because of all the contributions that are associated, and that someone re-saved the change a few times.

Is it possible there's also confusion around the 'Financial Type' and the 'Payment Method'? There are payments that have both 'Financial Type'='Cash' and 'Payment Method'='Cash', and payments with 'Financial Type'='Cash' and 'Payment Method'='EFT'.

@Ejegg the financial type 'cash' is correct. Originally the gift was entered with payment method 'cash' as well in error, but when I went to edit the method to change it to 'EFT' it created the extra positive and negative lines like you mentioned. Still the payment method didn't seem to update, so I tried again. This is the reason for the multiple positive and negative lines being created. I am hesitant to keep trying the edit and just create more and more lines. I don't want to clutter things up too much. Let me know if you have ideas on anything I can do differently and I am happy to try it out!

@Ejegg I will also be at the civi fortnightly today, happy to discuss this then!

Change 642148 had a related patch set uploaded (by Mepps; owner: Mepps):
[wikimedia/fundraising/crm/civicrm@master] Save new paymethod type on edit of payment

I fixed this contribution - using the search kit - but the patch above seems to not work because the payment edit form bypasses the Payment code

Ideally we would

  1. fix the Payment edit form to call that code and then
  2. add a patch similar to @mepps patch

Given this is a long standing gotcha that only got noticed now I'm wondering if fixing the payment in question isn't enough for now

@Eileenmcnaughton Thank you for fixing the payment method! I saw that the gift is not on the CID 72 record. Is there a way to get it to show up there?

DStrine triaged this task as Medium priority.Dec 3 2020, 8:21 PM