"Advanced" drawer doesn't open when clicking it.
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
Exception is thrown:
Uncaught TypeError: Cannot read property 'saveOption' of undefined at ReplyWidgetPlain.ReplyWidget.onAdvancedToggleClick (load.php?lang=en&modules=ext.discussionTools.ReplyWidget|oojs-ui-widgets&skin=vector&version=5p9oz:8) at OoUiButtonWidget.OO.EventEmitter.emit (<anonymous>:265:483) at OoUiButtonWidget.OO.ui.mixin.ButtonElement.onClick (load.php?lang=en&modules=ext.discussionTools.init|ext.eventLogging|ext.uls.interface|jquery%2Coojs-ui-core|mediawiki.jqueryMsg%2Cutil|skins.vector.legacy.js&skin=vector&version=xolbf:435) at HTMLAnchorElement.dispatch (load.php?lang=en&modules=ext.discussionTools.init|ext.eventLogging|ext.uls.interface|jquery%2Coojs-ui-core|mediawiki.jqueryMsg%2Cutil|skins.vector.legacy.js&skin=vector&version=xolbf:323) at HTMLAnchorElement.elemData.handle (load.php?lang=en&modules=ext.discussionTools.init|ext.eventLogging|ext.uls.interface|jquery%2Coojs-ui-core|mediawiki.jqueryMsg%2Cutil|skins.vector.legacy.js&skin=vector&version=xolbf:320)
Comment Actions
Change 636981 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix exception when toggling the "Advanced" drawer
Comment Actions
This was caused by a "logical merge conflict" between rEDTO3b31aa669dd1: Create controller.getApi method with defaults and rEDTO2f28cfdf5667: Add preference to expand the "Advanced" menu when replying. Both of these patches work correctly separately, but the first one removes some code that the second one has relies on. When we merged them both, we got the problem.
Comment Actions
Change 636981 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Fix exception when toggling the "Advanced" drawer