Page MenuHomePhabricator

Use a proper yaml parser in Toolforge buildpacks
Closed, ResolvedPublic

Description

The current python3.7 detect script contains:

grep -q 'type: python3.7' service.template || exit 100
echo "Python 3.7 buildpack"

Since service.template is supposed to be yaml, that grep could fail in so many ways. We should just use a proper yaml parser to avoid this hack. Also it'll be needed for more advanced constructs, like lists.

Event Timeline

Change 637199 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[operations/docker-images/toollabs-images@master] [WIP] Install yj in buster0 stack

https://gerrit.wikimedia.org/r/637199

Andrew triaged this task as Low priority.Dec 8 2020, 5:53 PM

Change 637199 abandoned by BryanDavis:

[operations/docker-images/toollabs-images@master] [WIP] Install yj in buster0 stack

Reason:

buster0 images removed by I8bb60ee5560754cb6b467b5ed6ee78cb3da608c3

https://gerrit.wikimedia.org/r/637199

dcaro claimed this task.
dcaro subscribed.

I think this does not apply anymore, we are using upstream buildpacks